Implement GET query params #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| } | ||
| query = Object.keys(queryObject) | ||
| // Filter any keys with values that evaluate to false | ||
| .filter(key => !!queryObject[key]) |
There was a problem hiding this comment.
Is this desirable? Could there not be a case where sending a zero makes sense and should be possible? If I'm not mistaken, a query-object like { max_length: 0 } will be a no-op. Is that good? I'm not sure!
There was a problem hiding this comment.
Yes you're right! I will filter on !== false instead.
index.js
Outdated
| if(queryObject[key] === true) { | ||
| return key; | ||
| } else { | ||
| return key + '=' + queryObject[key]; |
There was a problem hiding this comment.
How does it deal with escaping/URL encoding? What happens if you pass an object like { foo: "bar&baz" }?
There was a problem hiding this comment.
Yup, this could present problems, I will add url encoding.
…rt that invalid query argument location throws error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32