Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes view scroll bug #1262

Closed

Conversation

deSelbyPsyche
Copy link
Contributor

Adds overflow css so that the window can be scrolled horizontally on a large screen as well as a small screen, fixes #1253

@niklasva82 niklasva82 self-requested a review March 20, 2021 11:31
Copy link
Member

@niklasva82 niklasva82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! But there is a bug here.

The fix works as expected when no people have been added, but as soon as people are added to the view and scroll is needed, two scroll bars appear.

This appears to be because the existing scroll is on the table body, and the new scroll is on table. If you remove the scroll from the table body, the problem will likely be resolved.

@richardolsson
Copy link
Member

This appears to be because the existing scroll is on the table body, and the new scroll is on table. If you remove the scroll from the table body, the problem will likely be resolved.

The reason why the scrollbar was on tbody (and the root cause of this bug) is that we want to be able to scroll the body of the table vertically without the header scrolling out of view, i.e. a "sticky header". As far as I know, that can't be achieved without a JS hack like the one employed here, where the header is scrolled programmatically as an effect of the user scrolling the body.

So I think the strategy applied here might not be the right way to achieve a solution. But it would be interesting to see if having vertical scrolling on body and horizontal scrolling on the entire table would be an acceptable solution. I'm not sure how the browsers would handle that, but it's worth a try! 😊

@richardolsson
Copy link
Member

Closing this as stale. This issue does not exist in Gen3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot scroll right on view header without people in view
3 participants