Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-request lock is ignored in edge cases #56

Open
WULCAN opened this issue Mar 14, 2024 · 0 comments
Open

pull-request lock is ignored in edge cases #56

WULCAN opened this issue Mar 14, 2024 · 0 comments

Comments

@WULCAN
Copy link
Collaborator

WULCAN commented Mar 14, 2024

On e5d3297, the route for creating a pull request implements a lock to reduce the risk of concurrent calls interfering with each other.

We have another integration with the local git clone in Cache.gitPullIfNeeded and this does not respect the lock so some risk remains.

gitPullIfNeeded does no work on the local git clone if the project has already been loaded into Lyra and normally, the language will have been loaded before creating any pull request.

The risk of any interference during normal use is very low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant