Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include zapp version in .zapp filename on zpm bundle #149

Open
larsbutler opened this issue Jul 8, 2014 · 2 comments
Open

Include zapp version in .zapp filename on zpm bundle #149

larsbutler opened this issue Jul 8, 2014 · 2 comments

Comments

@larsbutler
Copy link
Member

The ZPA spec suggests a naming convention for zapps. It might be useful to include the version (from the zapp.yaml) in the build .zapp filename.

For example, a zapp called foo with version 0.2-1 would result in a foo-0.2-1.zapp file on zpm bundle.

@mgeisler
Copy link
Contributor

mgeisler commented Jul 8, 2014

This implies that we will have to restrict version numbers so they cannot contain / and \. Alternatively, we will have to map these characters to something else when we form for filename.

@larsbutler
Copy link
Member Author

Yeah, I'm in favor of restricting the version numbers to a certain pattern. Something like the debian version scheme would be a good place to start. We could do something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants