Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept threshold values for calculating neighbours #242

Closed
pfebrer opened this issue Jul 13, 2020 · 0 comments
Closed

Accept threshold values for calculating neighbours #242

pfebrer opened this issue Jul 13, 2020 · 0 comments

Comments

@pfebrer
Copy link
Contributor

pfebrer commented Jul 13, 2020

As you may have noticed, I'm playing with categories :)

Right now, the AtomNeighbours category only works if you have a well defined basis for each atom, otherwise it throws an error because the maxR is smaller than 0.01.

What would be the best approach if I want to calculate neighbours for a geometry that I just created in sisl without specifying any orbitals? I think it is worth it to accept thresholds for each kind of atom in AtomNeighbours as you proposed in #218 (comment) and/or use defaults extracted from PeriodicTable.

And by the way I also agree that calculating neighbours based on orbital overlapping would be better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant