From b4af71ed5bbceeb0aaed1c110c040d0c12cec437 Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 15 Nov 2024 10:33:16 -0500 Subject: [PATCH 1/9] Add Linux core dumps --- .github/workflows/ci.yml | 13 +++++++++++++ cpp/test/Ice/properties/Client.cpp | 2 ++ 2 files changed, 15 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9e0cd7db24f..f3223257c30 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -93,6 +93,11 @@ jobs: with: use_matlab: ${{ matrix.config == 'matlab' }} + - name: Enable Linux core dumps + run: | + ulimit -c unlimited + if: runner.os == 'Linux' + # See https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps - name: Enable Windows crash dumps run: | @@ -128,6 +133,14 @@ jobs: if-no-files-found: ignore if: always() + - name: Upload Linux core dumps + uses: actions/upload-artifact@v4 + with: + name: core-dumps-${{ matrix.config }}-${{ matrix.os }} + path: /var/lib/apport/coredump/* + if-no-files-found: ignore + if: runner.os == 'Linux' && always() + - name: Upload macOS crash diagnostics uses: actions/upload-artifact@v4 with: diff --git a/cpp/test/Ice/properties/Client.cpp b/cpp/test/Ice/properties/Client.cpp index 1d56967d44d..21b01fa459b 100644 --- a/cpp/test/Ice/properties/Client.cpp +++ b/cpp/test/Ice/properties/Client.cpp @@ -215,6 +215,8 @@ Client::run(int, char**) test(properties->getProperty("Ice.MessageSizeMax") == "20"); cout << "ok" << endl; } + + assert(false); } DEFINE_TEST(Client) From a49c6ee7f1cedfa51160b15698b6640a6641a8c6 Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 15 Nov 2024 11:26:12 -0500 Subject: [PATCH 2/9] fixes --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f3223257c30..db5aa46c554 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,7 +95,9 @@ jobs: - name: Enable Linux core dumps run: | - ulimit -c unlimited + echo "ulimit -c unlimited" >> ~/.bashrc + echo "/tmp/core.%e.%p.%t.%h" > /proc/sys/kernel/core_pattern + if: runner.os == 'Linux' # See https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps @@ -137,7 +139,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: core-dumps-${{ matrix.config }}-${{ matrix.os }} - path: /var/lib/apport/coredump/* + path: /tmp/core.* if-no-files-found: ignore if: runner.os == 'Linux' && always() From 062dec60197b1b1380b44a340cb223219d1c69fa Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 15 Nov 2024 11:28:28 -0500 Subject: [PATCH 3/9] fixes --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db5aa46c554..6a7e39458e1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -96,7 +96,7 @@ jobs: - name: Enable Linux core dumps run: | echo "ulimit -c unlimited" >> ~/.bashrc - echo "/tmp/core.%e.%p.%t.%h" > /proc/sys/kernel/core_pattern + echo "core.%e.%p.%t.%h" > /proc/sys/kernel/core_pattern if: runner.os == 'Linux' @@ -139,7 +139,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: core-dumps-${{ matrix.config }}-${{ matrix.os }} - path: /tmp/core.* + path: ${{ matrix.working_directory || '.' }}/**/core.* if-no-files-found: ignore if: runner.os == 'Linux' && always() From a0df566911949108117e4d9b3b92deef4f697654 Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 15 Nov 2024 11:42:12 -0500 Subject: [PATCH 4/9] fix --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6a7e39458e1..5ec9e8216ed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -96,7 +96,7 @@ jobs: - name: Enable Linux core dumps run: | echo "ulimit -c unlimited" >> ~/.bashrc - echo "core.%e.%p.%t.%h" > /proc/sys/kernel/core_pattern + echo "core.%e.%p.%t.%h" > sudo tee /proc/sys/kernel/core_pattern if: runner.os == 'Linux' From eaf92bd7e01434da73cf8e696b4552effbaeebd5 Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 15 Nov 2024 13:38:43 -0500 Subject: [PATCH 5/9] tsets --- .github/actions/test/action.yml | 10 +++++++++- .github/workflows/ci.yml | 7 ++----- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/actions/test/action.yml b/.github/actions/test/action.yml index 371f0baeb3f..3c4918f55ab 100644 --- a/.github/actions/test/action.yml +++ b/.github/actions/test/action.yml @@ -17,7 +17,15 @@ runs: working-directory: ${{ inputs.working_directory }} run: python3 allTests.py --debug --all --continue --workers=4 --export-xml=test-report.xml ${{ inputs.flags }} shell: bash - if: runner.os == 'macOS' || runner.os == 'Linux' + if: runner.os == 'macOS' + + - name: Test + working-directory: ${{ inputs.working_directory }} + run: | + ulimit -c unlimited + python3 allTests.py --debug --all --continue --workers=4 --export-xml=test-report.xml ${{ inputs.flags }} + shell: bash + if: runner.os == 'Linux' - name: Test working-directory: ${{ inputs.working_directory }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5ec9e8216ed..ae10ea561d6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,10 +94,7 @@ jobs: use_matlab: ${{ matrix.config == 'matlab' }} - name: Enable Linux core dumps - run: | - echo "ulimit -c unlimited" >> ~/.bashrc - echo "core.%e.%p.%t.%h" > sudo tee /proc/sys/kernel/core_pattern - + run: echo "coredump.%e.%p.%t.%h" > sudo tee /proc/sys/kernel/core_pattern if: runner.os == 'Linux' # See https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps @@ -139,7 +136,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: core-dumps-${{ matrix.config }}-${{ matrix.os }} - path: ${{ matrix.working_directory || '.' }}/**/core.* + path: ${{ matrix.working_directory || '.' }}/**/coredump.* if-no-files-found: ignore if: runner.os == 'Linux' && always() From a2d6cd15fa7c09ecf537146a67aa34eb29f3da9d Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 15 Nov 2024 14:58:08 -0500 Subject: [PATCH 6/9] fix indentation --- .github/actions/test/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/test/action.yml b/.github/actions/test/action.yml index 3c4918f55ab..b9f6a9c029c 100644 --- a/.github/actions/test/action.yml +++ b/.github/actions/test/action.yml @@ -19,7 +19,7 @@ runs: shell: bash if: runner.os == 'macOS' - - name: Test + - name: Test working-directory: ${{ inputs.working_directory }} run: | ulimit -c unlimited From ec64c1d072af5ea622fa6d35420c47246d757abd Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 15 Nov 2024 15:39:57 -0500 Subject: [PATCH 7/9] change coredump dir --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ae10ea561d6..82bd91a9fd8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,7 +94,7 @@ jobs: use_matlab: ${{ matrix.config == 'matlab' }} - name: Enable Linux core dumps - run: echo "coredump.%e.%p.%t.%h" > sudo tee /proc/sys/kernel/core_pattern + run: echo "/tmp/coredump/coredump.%e.%p.%t.%h" > sudo tee /proc/sys/kernel/core_pattern if: runner.os == 'Linux' # See https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps @@ -136,7 +136,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: core-dumps-${{ matrix.config }}-${{ matrix.os }} - path: ${{ matrix.working_directory || '.' }}/**/coredump.* + path: /tmp/coredump/coredump.* if-no-files-found: ignore if: runner.os == 'Linux' && always() From e28f98c9fc16bcd58344bff7c28c81f4a5a36ca9 Mon Sep 17 00:00:00 2001 From: Joe George Date: Wed, 20 Nov 2024 11:17:07 -0500 Subject: [PATCH 8/9] Try with apport --- .github/workflows/ci.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 82bd91a9fd8..94ea07a871e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -93,10 +93,6 @@ jobs: with: use_matlab: ${{ matrix.config == 'matlab' }} - - name: Enable Linux core dumps - run: echo "/tmp/coredump/coredump.%e.%p.%t.%h" > sudo tee /proc/sys/kernel/core_pattern - if: runner.os == 'Linux' - # See https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps - name: Enable Windows crash dumps run: | @@ -136,7 +132,15 @@ jobs: uses: actions/upload-artifact@v4 with: name: core-dumps-${{ matrix.config }}-${{ matrix.os }} - path: /tmp/coredump/coredump.* + path: /var/lib/apport/coredump/* + if-no-files-found: ignore + if: runner.os == 'Linux' && always() + + - name: Upload Linux core dumps + uses: actions/upload-artifact@v4 + with: + name: apport-log-${{ matrix.config }}-${{ matrix.os }} + path: /var/log/apport.log if-no-files-found: ignore if: runner.os == 'Linux' && always() From 7784c781e0f43e8676f93bacd703f67a413cac39 Mon Sep 17 00:00:00 2001 From: Joe George Date: Thu, 21 Nov 2024 14:21:14 -0500 Subject: [PATCH 9/9] Cleanup --- .github/workflows/ci.yml | 8 -------- cpp/test/Ice/properties/Client.cpp | 2 -- 2 files changed, 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 94ea07a871e..37edfb050f5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -136,14 +136,6 @@ jobs: if-no-files-found: ignore if: runner.os == 'Linux' && always() - - name: Upload Linux core dumps - uses: actions/upload-artifact@v4 - with: - name: apport-log-${{ matrix.config }}-${{ matrix.os }} - path: /var/log/apport.log - if-no-files-found: ignore - if: runner.os == 'Linux' && always() - - name: Upload macOS crash diagnostics uses: actions/upload-artifact@v4 with: diff --git a/cpp/test/Ice/properties/Client.cpp b/cpp/test/Ice/properties/Client.cpp index 8b4401215ff..0353bc8e11d 100644 --- a/cpp/test/Ice/properties/Client.cpp +++ b/cpp/test/Ice/properties/Client.cpp @@ -230,8 +230,6 @@ Client::run(int, char**) } cout << "ok" << endl; } - - test(false); } DEFINE_TEST(Client)