Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ice2slice Does Not Honor --output-dir Command Line Argument #3289

Open
InsertCreativityHere opened this issue Dec 18, 2024 · 0 comments · May be fixed by #3308
Open

ice2slice Does Not Honor --output-dir Command Line Argument #3289

InsertCreativityHere opened this issue Dec 18, 2024 · 0 comments · May be fixed by #3308
Assignees
@pepone
Labels
bug ice2slice
Milestone
3.8.0

Comments

@InsertCreativityHere
Copy link
Member

Like all other Slice compilers, ice2slice's help dialogue includes:

"--output-dir DIR         Create files in the directory DIR.\n"

and we go through the trouble of parsing this argument:

opts.addOpt("", "output-dir", IceInternal::Options::NeedArg);
...
string output = opts.optArg("output-dir");

But we never actually use this variable. So passing this argument to ice2slice has no effect.

We should fix ice2slice to honor this variable like the other compilers do.
@InsertCreativityHere InsertCreativityHere added this to the 3.8.0 milestone Dec 18, 2024
@pepone pepone self-assigned this Dec 26, 2024
pepone added a commit to pepone/ice that referenced this issue Dec 26, 2024
@pepone
Fix ice2slice to honor --output-dir - zeroc-ice#3289
654d030
@pepone pepone linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepone pepone

Labels
bug ice2slice
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Fix ice2slice to honor --output-dir pepone/ice
2 participants
@pepone @InsertCreativityHere