Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecatedBy from properties #2107

Closed
externl opened this issue May 2, 2024 · 0 comments · Fixed by #2182
Closed

Remove deprecatedBy from properties #2107

externl opened this issue May 2, 2024 · 0 comments · Fixed by #2182
Assignees
Milestone

Comments

@externl
Copy link
Member

externl commented May 2, 2024

          Yes, I want to get rid of this code as well.

Originally posted by @externl in #2100 (comment)

Our Ice property code currently supports deprecating one property by another, with the assumption they're still "compatible". We then also perform an extra check when setting a property which is deprecated by another one. If "Foo" is deprecated by "Bar", we actually set "Bar" (silently) but warning that "Foo" is deprecated.

I think we should remove this functionality.

  1. Deprecating something means it still works for now but will be removed in the future. We actually just set a different property making it confusing if you attempt to look this property up in the future.
  2. If we do want to deprecate a property we should mark it as deprecated and still actually check it in code. In a future release we would remove it and its use entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant