I think we can update toUpper/toLower to work with string_view in a follow up PR, what do you think? #2106
Comments
externl
added a commit
that referenced
this issue
May 7, 2024
Updates the generated property code to include a boolean indicating if the property uses regular expressions for matching. It also removes the case sensitivity check on the property names in favor of a check on the prefix. Now, if a property does not require regex we just do a plain string comparison. Closes #2108 and #2106
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this issue
Jan 1, 2025
…ng (zeroc-ice/ice#2122) Updates the generated property code to include a boolean indicating if the property uses regular expressions for matching. It also removes the case sensitivity check on the property names in favor of a check on the prefix. Now, if a property does not require regex we just do a plain string comparison. Closes zeroc-ice/ice#2108 and zeroc-ice/ice#2106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @pepone in #2100 (comment)
Our property code currently performs an extra case-insensitive check and issue a warning if there's a case mismatch. I think we should remove this as we already warn for unknown properties.
The text was updated successfully, but these errors were encountered: