From 2f7a83b635524eac39706d005643c33bd0996f42 Mon Sep 17 00:00:00 2001 From: Jose Date: Mon, 28 Oct 2024 19:31:04 +0100 Subject: [PATCH] No need to destroy endpoint factories in JavaScript --- js/src/Ice/EndpointFactoryManager.js | 5 ----- js/src/Ice/InstanceExtensions.js | 3 --- js/src/Ice/TcpEndpointFactory.js | 4 ---- js/src/Ice/WSEndpointFactory.js | 5 ----- 4 files changed, 17 deletions(-) diff --git a/js/src/Ice/EndpointFactoryManager.js b/js/src/Ice/EndpointFactoryManager.js index e37cc685a07..d7de29218cd 100644 --- a/js/src/Ice/EndpointFactoryManager.js +++ b/js/src/Ice/EndpointFactoryManager.js @@ -110,9 +110,4 @@ export class EndpointFactoryManager { s.endEncapsulation(); return e; } - - destroy() { - this._factories.forEach(factory => factory.destroy()); - this._factories = []; - } } diff --git a/js/src/Ice/InstanceExtensions.js b/js/src/Ice/InstanceExtensions.js index 22ab7687177..940c60da0dd 100644 --- a/js/src/Ice/InstanceExtensions.js +++ b/js/src/Ice/InstanceExtensions.js @@ -360,9 +360,6 @@ Instance.prototype.destroy = async function () { if (this._locatorManager) { this._locatorManager.destroy(); } - if (this._endpointFactoryManager) { - this._endpointFactoryManager.destroy(); - } if (this._initData.properties.getPropertyAsInt("Ice.Warn.UnusedProperties") > 0) { const unusedProperties = this._initData.properties.getUnusedProperties(); diff --git a/js/src/Ice/TcpEndpointFactory.js b/js/src/Ice/TcpEndpointFactory.js index 5f81be4b6c6..3dbe29f53c7 100644 --- a/js/src/Ice/TcpEndpointFactory.js +++ b/js/src/Ice/TcpEndpointFactory.js @@ -29,10 +29,6 @@ export class TcpEndpointFactory { return e; } - destroy() { - this._instance = null; - } - clone(instance) { return new TcpEndpointFactory(instance); } diff --git a/js/src/Ice/WSEndpointFactory.js b/js/src/Ice/WSEndpointFactory.js index e6195ee8822..a168021c416 100644 --- a/js/src/Ice/WSEndpointFactory.js +++ b/js/src/Ice/WSEndpointFactory.js @@ -29,9 +29,4 @@ export class WSEndpointFactory { e.initWithStream(s); return e; } - - destroy() { - this._delegate.destroy(); - this._instance = null; - } }