Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Discuss overloading transaction function calls with gas estimation in contract wrapper #214

Open
spalladino opened this issue Jul 20, 2018 · 1 comment
Labels
kind:discussion To discuss on a task before implementing it
Milestone

Comments

@spalladino
Copy link
Contributor

We currently have a custom sendTransaction method (implemented in #211) that estimates the gas of a tx. We could overload all the functions in a contract that correspond to a transaction to actually use them, so any user requesting a contract from zos-lib Contracts helper has this feature enabled automatically.

This would also allow us to roll back to using the default function syntax, instead of using the sendTransaction raw call.

@spalladino spalladino added the kind:discussion To discuss on a task before implementing it label Jul 20, 2018
@spalladino spalladino added this to the v2.0.0 milestone Jul 20, 2018
@spalladino spalladino changed the title Discuss overloading transaction function calls in contract wrapper Discuss overloading transaction function calls with gas estimation in contract wrapper Jul 20, 2018
@facuspagnuolo
Copy link
Contributor

Another alternative could be to provide different instances of the Contracts object and in that case, we will be letting users decide which one they would prefer to use. And it will allow us to use the already known function syntax too.

@facuspagnuolo facuspagnuolo modified the milestones: v2.0.0, Backlog Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:discussion To discuss on a task before implementing it
Projects
None yet
Development

No branches or pull requests

2 participants