Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2dplot small improvements #28

Open
wants to merge 7 commits into
base: uPlot
Choose a base branch
from
Open

Conversation

Math-42
Copy link
Member

@Math-42 Math-42 commented Nov 3, 2021

What type of PR is this? (check all applicable)

  • ✨ Feature
  • 🐞 Bug Correction
  • 📝 Documentation Update
  • 🚩 Other

Changes:

Adicionando pequenas modificações no plot 2D:

Correção do bug de remoção da última série.
Corrigindo typos.
Ajustando uso da escala log.
Remoção de incoêrencias entre o plot e o menu de edição.
Adicionando grid no visual inicial do plot.
Adicionando plugin de zoom com a roda do mouse.

closes #12

Testing

@Math-42 Math-42 added bug Something isn't working enhancement New feature or request labels Nov 3, 2021
@Math-42 Math-42 self-assigned this Nov 3, 2021
Copy link
Member

@mairacanal mairacanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Além da correção equivocada do typo, o padrão dos commits está completamente errado. Tem commits em português, tem commits que a label não é o nome da classe, mas sim, uma label genérica, como fix. De resto, acho que ficou bom.

assets/blocksConfig/PlotlySection.json Outdated Show resolved Hide resolved
assets/blocksConfig/PlotlySection.json Outdated Show resolved Hide resolved
Comment on lines +1 to +2


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linha vazias

src/components/blocks/Blocks/uPlot/plugins/zoom-wheel.js Outdated Show resolved Hide resolved
src/components/blocks/Blocks/uPlot/plugins/zoom-wheel.js Outdated Show resolved Hide resolved
{
text: 'Embaixo',
value: 2
}, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrigir o {

assets/blocksConfig/uPlotSection.json Outdated Show resolved Hide resolved
src/components/blocks/Blocks/uPlot/scatter.js Outdated Show resolved Hide resolved
src/components/blocks/Blocks/uPlot/scatter.js Outdated Show resolved Hide resolved
src/components/blocks/Blocks/uPlot/scatter.js Outdated Show resolved Hide resolved
Copy link
Member

@Grillo-0 Grillo-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quando acaba a simulação o zoom pelo scroll n funciona direito e para voltar a funcionar alguma coisa tem que ser mexida na edição do plot

@Math-42 Math-42 force-pushed the 2dplot-visual-improvement branch from a38aea8 to 6758f77 Compare November 18, 2021 00:52
Copy link
Member

@mairacanal mairacanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse PR saiu completamente do escopo. Tirar o Plotly do repositório deveria ser em outro PR, senão esse PR fica muito grande e sem escopo definido.

Além disso, comentários meus da primeira revisão ainda não foram solucionados.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bloco + Menu do Bloco: Gráfico 2D
3 participants