-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2dplot small improvements #28
base: uPlot
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Além da correção equivocada do typo, o padrão dos commits está completamente errado. Tem commits em português, tem commits que a label não é o nome da classe, mas sim, uma label genérica, como fix
. De resto, acho que ficou bom.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linha vazias
src/components/sideMenu/menus/EditMenu/menus/uPlot/types/scatter.js
Outdated
Show resolved
Hide resolved
{ | ||
text: 'Embaixo', | ||
value: 2 | ||
}, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrigir o {
src/components/sideMenu/menus/EditMenu/menus/uPlot/types/scatter.js
Outdated
Show resolved
Hide resolved
src/components/sideMenu/menus/EditMenu/menus/uPlot/types/scatter.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quando acaba a simulação o zoom pelo scroll n funciona direito e para voltar a funcionar alguma coisa tem que ser mexida na edição do plot
a38aea8
to
6758f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse PR saiu completamente do escopo. Tirar o Plotly do repositório deveria ser em outro PR, senão esse PR fica muito grande e sem escopo definido.
Além disso, comentários meus da primeira revisão ainda não foram solucionados.
What type of PR is this? (check all applicable)
Changes:
Adicionando pequenas modificações no plot 2D:
Correção do bug de remoção da última série.
Corrigindo typos.
Ajustando uso da escala log.
Remoção de incoêrencias entre o plot e o menu de edição.
Adicionando grid no visual inicial do plot.
Adicionando plugin de zoom com a roda do mouse.
closes #12
Testing