Samson creates release for non-existent commit

[orien]

Context

We had erroneously configured Buildkite to notify project A in Samson on builds for project B in Buildkite. Under this scenario Samson will attempt to create a new release for project B. Resulting in errors and confusion.

Proposal

Samson could handle this situation more gracefully. It could perhaps:

• Only respond to Buildkite webhook notifications for the same git repo (the git URL is included in the webhook payload).
• Only attempt to cut a release if the commit specified in the Buildkite webhook exists in the project repository.

[grosser]

PR welcome, but this sounds tricky to get just right :(

…

On Tue, Dec 15, 2020 at 3:47 PM Orien Madgwick ***@***.***> wrote: Context We had erroneously configured Buildkite to notify a project A in Samson on builds for project B in Buildkite. Under this scenario Samson will attempt to create a new release for project B. Resulting in errors and confusion. Proposal Samson could handle this situation more gracefully. It could perhaps: - Only respond to Buildkite webhook notifications for the same git repo (the git URL is included in the webhook payload). - Only attempt to cut a release if the commit specified in the Buildkite webhook exists in the project repository. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3900>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACYZZVTVA2D7M5HQ34ZFLSU7YSTANCNFSM4U5EONYA> .