Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Learn All" words button (execution) is very slow #190

Open
leeterry opened this issue Jul 31, 2024 · 2 comments
Open

[Bug] "Learn All" words button (execution) is very slow #190

leeterry opened this issue Jul 31, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@leeterry
Copy link

Description

After finally getting it to work (see my post in the other bug report). I loaded my save and attempted to edit my languages/milestones (hoping to get rid of the spam messages). However, the editor froze when I clocked the learn all button and became unresponsive for a few seconds. After that time had passed and it started working again nothing had changed despite my pressing the button and clicking each option to learn the words manually had the same result.

@leeterry leeterry added the bug Something isn't working label Jul 31, 2024
@cengelha
Copy link
Member

cengelha commented Aug 4, 2024

The current implementation isn't ideal. The "Learn all" just unlocks each as it would when you manually unlock it which is quiet heavy. For each word it first has to find and update the actual value and then it has to find and update the WORDS_LEARNT stats by counting all for the global number and then counting again for the race.
For examaple there are over 900 words for the Gek and just takes it time to do this for all of them. Would be better to just update the value and count once afterwards (or just set it to the total no of words as we know that number).

Beside that it does what it should. I just tested it and all checkbox were set and after saving and restarting NN all words were still marked as unlocked.

I'll keep this open as remainder to improve it in the future ;)

@cengelha cengelha added this to the Uno milestone Aug 4, 2024
@cengelha cengelha changed the title [Bug] [Bug] "Learn All" words button (execution) is very slow Aug 4, 2024
@fureimu
Copy link

fureimu commented Oct 29, 2024

Hello there!
"Learn all" button currently (at curse exp version) completely hangs the app. Its constantly using precisely 10% of my CPU and 771.5 MB of RAM and nothing happens. No disk activity there. The app does not respond.

Windows 10, Ryzen 1600 CPU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants