Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zellij handling "Alt Shift" incorrectly/inconsistently in Alacritty #3817

Closed
bcspragu opened this issue Nov 28, 2024 · 6 comments
Closed

Zellij handling "Alt Shift" incorrectly/inconsistently in Alacritty #3817

bcspragu opened this issue Nov 28, 2024 · 6 comments

Comments

@bcspragu
Copy link

2. Issues with the Zellij UI / behavior / crash

Issue description

I've observed some odd behavior for using "Alt Shift" in terminal applications, where the whole key combo is either swallowed or the "Shift" key is ignored.

Minimal reproduction

For example, in Helix:

  • Pressing Alt-Shift-k (i.e. Alt-K)

    • [Not in Zellij] Triggers the "remove selections matching regex" command
    • [In Zellij] Does nothing
  • Pressing Alt-Shift-j (i.e. Alt-J)

    • [Not in Zellij] Triggers the "join lines and select the spaces" command
    • [In Zellij] Does nothing
  • Pressing Alt-Shift-; (i.e. `Alt-:)

    • [Not in Zellij] Triggers the "Ensure selection is at the end" command
    • [In Zellij] Triggers the command mapped to Alt-; (e.g. the command you'd execute if not pressing Shift)

All of these tests done with zellij setup --clean. I'm not sure why ;/: behaves differently, could be because there's no Zellij binding for those?

Other relevant information

I tried unbind "Alt Shift k" "Alt K", but the behavior was the same.

Note: after testing this, I tried some other terminals, and they all behaved differently 🙃

  • xterm - Alt-Shift-* bindings don't work in or out of Zellij
  • rxvt-unicode - Alt-Shift-* bindings work correctly in and out of Zellij

So that's odd, but I'm still inclined to call this a Zellij issue (i.e. as opposed to an Alacritty issue) because the behavior changes when using Zellij

@v0idh4nd
Copy link

v0idh4nd commented Dec 2, 2024

+1

@v0idh4nd
Copy link

v0idh4nd commented Dec 2, 2024

Disabling
support_kitty_keyboard_protocol false
solves the problem

@bcspragu
Copy link
Author

bcspragu commented Dec 2, 2024

Disabling support_kitty_keyboard_protocol false solves the problem

I can confirm it does! No idea what other implications there are for this change (I don't think Alacritty supports anything from Kitty), but it definitely fixes the issue, thanks!

Marking this one as closed in favor of #3789

@bcspragu bcspragu closed this as completed Dec 2, 2024
@blixenkrone
Copy link

Disabling support_kitty_keyboard_protocol false solves the problem

Disabling this in Alacritty, or what is this reference?

@bcspragu
Copy link
Author

bcspragu commented Dec 3, 2024

Disabling this in Alacritty, or what is this reference?

In Zellij, e.g. in ~/.config/zellij/config.kdl:

keybinds clear-defaults=true { ... }

// other stuff

support_kitty_keyboard_protocol false

@blixenkrone
Copy link

blixenkrone commented Dec 3, 2024

Disabling this in Alacritty, or what is this reference?

In Zellij, e.g. in ~/.config/zellij/config.kdl:

keybinds clear-defaults=true { ... }

// other stuff

support_kitty_keyboard_protocol false

Boy oh boy, this seemingly fixed the majority of issues I raised in #3789.
I'll update the thread, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants