How to forward option-enter (alt-enter) to terminal?

[schpet]

i'm having trouble sending option-enter keypresses to the terminal, i've read this

https://zed.dev/docs/key-bindings#forward-keys-to-terminal

and in my keymap i've tried the following:

[
  {
    "context": "Terminal",
    "bindings": {
      "alt-enter": ["terminal::SendKeystroke", "Alt+Enter"]
    }
  }
]

i've also tried the option_as_meta setting, and using the mac command key

{
  "terminal": {
    "option_as_meta": true
  }
}

but no dice so far. i use option-enter to write newlines in aider.

[notpeter]

I believe it should be "alt-enter" not "Alt+Enter" (untested)

[schpet]

thanks for checking this out! i've tried these two combinations as well:

      "alt-enter": ["terminal::SendKeystroke", "alt-enter"]
      "alt-enter": ["terminal::SendKeystroke", "alt+enter"]

both with and without option_as_meta but no luck. i also observed that i cannot make this work with alacritty proper either, so maybe some sort of cursed meta/alt behaviour on mac os.

[schpet]

here's what i see without any alt-enter overrides in keymap.json, and "option_as_meta": true, zed on left, terminal.app on right

[notpeter]

Yeah, I just did the same thing but with fish_key_reader

We likely need to add alt-enter here:

zed/crates/terminal/src/mappings/keys.rs

Lines 52 to 54 in cc7c0a3

	("enter", AlacModifiers::None) => Some("\x0d".to_string()),
	("enter", AlacModifiers::Shift) => Some("\x0d".to_string()),
	("backspace", AlacModifiers::None) => Some("\x7f".to_string()),

Separately if you have a buffer search deployed it is also broken. The keymap here could use tweaking

zed/assets/keymaps/default-macos.json

Lines 221 to 229 in cc7c0a3

	{
	"context": "BufferSearchBar",
	"bindings": {
	"escape": "buffer_search::Dismiss",
	"tab": "buffer_search::FocusEditor",
	"enter": "search::SelectNextMatch",
	"shift-enter": "search::SelectPrevMatch",
	"alt-enter": "search::SelectAllMatches",
	"cmd-f": "search::FocusSearch",

[notpeter]

Thanks for reporting. Fixed in:

• Fix sending alt-enter in terminal #18363

[schpet]

hey thanks so much for fixing this! also cool to learn about fish_key_reader, really straightforward way of understanding what's going on.