Skip to content

Patch Diff Additions and Deletions Not Highlighted #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CurbaiCode opened this issue Mar 29, 2024 · 3 comments · May be fixed by #12
Open

Patch Diff Additions and Deletions Not Highlighted #3

CurbaiCode opened this issue Mar 29, 2024 · 3 comments · May be fixed by #12

Comments

@CurbaiCode
Copy link

Lines starting with + or - are not highlighted. Also, sometimes .patch files are not recognized and the language has to be manually selected in Zed.
@d1y
Copy link
Collaborator

d1y commented Mar 29, 2024

Diff now only match *.diff file

https://github.com/d1y/git_firefly/blob/8bb3a5f6769ad6de95ec0bfe430a17ecfd4128c1/languages/diff/config.toml#L3

@CurbaiCode
Copy link
Author

CurbaiCode commented Mar 29, 2024 •
edited
Loading

OK, thanks for the info. Though for me, .diff files only have @@ lines highlighted.

@xhyrom
Copy link

xhyrom commented Jul 18, 2024 •
edited
Loading

same for me, any updates?

notpeter added a commit to notpeter/git_firefly that referenced this issue Feb 25, 2025
@notpeter
Remove "Diff" language.
abeeb68 
Zed now ships support for diff/patch files as a 1st class language.
See:
- zed-industries/zed#19129

Closes zed-extensions#3
@notpeter notpeter linked a pull request Feb 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "Diff" language. notpeter/git_firefly
3 participants
@d1y @CurbaiCode @xhyrom