Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misleading comment description in verify_proof function #778

Open
levs57 opened this issue May 22, 2023 · 0 comments
Open

misleading comment description in verify_proof function #778

levs57 opened this issue May 22, 2023 · 0 comments

Comments

@levs57
Copy link

levs57 commented May 22, 2023

The comment on this line

/// Returns a boolean indicating whether or not the proof is valid

suggests that the verify_proof function returns a bool value indicating whether a proof is correct or not.

However, this is misleading, in fact, it returns Result<V::Output, Error>, for a verification strategy V, which, is in fact, not boolean.

@levs57 levs57 changed the title misleading comment in verify misleading comment description in verify_proof function May 22, 2023
@thor314 thor314 mentioned this issue Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant