Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle moved issues #71

Open
str4d opened this issue Nov 2, 2024 · 0 comments
Open

Gracefully handle moved issues #71

str4d opened this issue Nov 2, 2024 · 0 comments

Comments

@str4d
Copy link
Collaborator

str4d commented Nov 2, 2024

TERMINATE_AT takes a set of issues, maps them to (repo_id, issue_number) tuples, and then later expects them to be in the DAG. This starts failing if an issue gets moved, e.g. zcash/librustzcash#1349 moved to zcash/wallet#5.

Rather than the renderer blowing up, we should check that all issues in TERMINATE_AT exist, and return a nicer error before trying to build the graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant