Skip to content

Commit

Permalink
remove outdated comment and add two TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
denniswittich committed Aug 30, 2023
1 parent 95df480 commit a1c556a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ name: Run Tests

on: [push]

# build job temporarily build without cache
# alternative pre connection to nvidia container:
# docker run -d -it --rm nvcr.io/nvidia/l4t-pytorch:r32.6.1-pth1.9-py3 echo "Nothing to do"

jobs:
pytest:
runs-on: [self-hosted, gpu]
Expand Down
2 changes: 2 additions & 0 deletions trainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ RUN apt update && \
rm -rf /var/lib/apt/lists/*
RUN python3 -m pip install --upgrade pip

# TODO httptools is required but the test run even if it is not installed ... we need to extend the tests
RUN python3 -m pip install seaborn thop coremltools onnx gsutil notebook wandb>=0.12.2 opencv-python==4.5.5.64 torchinfo python-dotenv httptools

WORKDIR /
Expand All @@ -32,6 +33,7 @@ WORKDIR /yolov5
RUN git checkout 342fe05e6c88221750ce7e90b7d2e8baabd397dc
COPY *.patch ./
RUN git apply confusion_matrices.patch && git apply clear_epochs.patch && git apply ignore_previous_fitness.patch && rm *.patch
# TODO there is no requirements.txt file ?!
RUN python3 -m pip install --no-cache -r requirements.txt
RUN pip uninstall -y nvidia-tensorboard nvidia-tensorboard-plugin-dlprof
# wts file generator for detector format
Expand Down

0 comments on commit a1c556a

Please sign in to comment.