-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should consolidated metadata always be executed at the store root? #2920
Comments
#2113 (comment) touches on this. That sounds like it was intentional on my part, though I don't see any discussion there about it. Reading that now, I'm not really sure I appreciated the magnitude of the change. IIRC I viewed it more as a relaxing of a requirement of zarr-v2. |
Is there actually a use case for consolidated metadata that is not at the root? It seems to me that every time you want consolidated metadata you would like to have it for the whole store, i.e. at the root. |
I would need to check the v2 implementation, but my recollection is that it didn't create consolidated metadata for the entire store, unless you called it with the root group. If you do So if you want to consolidate for the entire store in v3, you can still have that with In xarray's case, I guess the hope / expectation is that you can consolidate a specific group and have it show up in the root of the store? |
Zarr version
v3.0.5
Numcodecs version
v0.15.1
Python Version
Python 3.11
Operating System
Mac
Installation
conda/pip
Description
Zarr-Python 2's
consolidate_metadata
included apath
argument. However, regardless of the value provided topath
, the.zmetadata
JSON object was always placed at the root of the Store. This behavior changed in Zarr-Python 3. Was this intentional and if so, is it really what we want?I know @TomAugspurger gave this some thought when implementing consolidated metadata for zarr-python 3. So perhaps we just need to document that this change was indeed intentional?
Steps to reproduce
Additional output
xref: pydata/xarray#10020
The text was updated successfully, but these errors were encountered: