Using ArrayV3Metadata, kerchunk fill_value will always be coerced to a value, even though `null` is a valid fill_value for Zarr V2 #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

abarciauskas-bgse opened this issue Mar 6, 2025 · 0 comments

Labels

bug

Collaborator

abarciauskas-bgse commented Mar 6, 2025 •

edited

Loading

This issue follows when #453 is merged
🚧 If the fill_value passed to ArrayV3Metadata is None, ArrayV3Metadata will automatically coerce the fill_value to the default of the data type. For example, fill_value will be 0 if None is passed. This means that writing back to v2 metadata will generate a fill_value of the default for the data type, rather than set it as null, which is valid for Zarr V2. See also pydata/xarray#5475 (comment)

Originally posted by @abarciauskas-bgse in #429 (comment)

The text was updated successfully, but these errors were encountered:

abarciauskas-bgse changed the title 🚧 [If the fill_value passed to ArrayV3Metadata is None, ArrayV3Metadata will automatically coerce the fill_value to the default of the data type](https://github.com/zarr-developers/zarr-python/blob/v3.0.2/src/zarr/core/metadata/v3.py#L271-L272). For example, fill_value will be 0 if None is passed. This means that writing back to v2 metadata will generate a fill_value of the default for the data type, rather than set it as null, which is valid for Zarr V2. See also https://github.com/pydata/xarray/issues/5475#issuecomment-2383046633 Using ArrayV3Metadata, kerchunk fill_value will always be coerced to a value, even though null is a valid fill_value for Zarr V2

TomNicholas added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment