Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline set_requirements() #2

Open
pediejo opened this issue Dec 13, 2023 · 0 comments
Open

Streamline set_requirements() #2

pediejo opened this issue Dec 13, 2023 · 0 comments

Comments

@pediejo
Copy link
Contributor

pediejo commented Dec 13, 2023

Currently, each set_requirements() method has duplicated code. The reason for not having this method live in the base class of SubroutineModel is that the explicit arguments specified in any child class serve as type hints for those using the method. However, there may be a cleaner way to achieve this result that doesn't require as much code duplication. Investigate this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant