Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shopping cart moveToCart and saveForLater should not be GET's #20

Open
stevelacey opened this issue May 22, 2019 · 2 comments
Open

Shopping cart moveToCart and saveForLater should not be GET's #20

stevelacey opened this issue May 22, 2019 · 2 comments

Comments

@stevelacey
Copy link

A GET should never change data on the server - use a POST request for that

https://softwareengineering.stackexchange.com/a/188861/3464

GET ​/shoppingcart​/moveToCart​/{item_id}
Move a product to cart

GET ​/shoppingcart​/saveForLater​/{item_id}
Save a Product for latter
@edertaveiraturing
Copy link

Thank you @stevelacey for your feedback.

@oluudeh
Copy link

oluudeh commented May 31, 2019

Should this recommendation be incorporated into the endpoint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevelacey @oluudeh @edertaveiraturing