-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the proxy example to fit the current version of compose file #430
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'd assume that is because of the YAML syntax around anchors: Whoever wrote the templating seemed to already think of this: # zammad-docker-compose/docker-compose.yml
x-shared:
zammad-service: &zammad-service
environment: &zammad-environment # <-- this line
MEMCACHE_SERVERS: ${MEMCACHE_SERVERS:-zammad-memcached:11211} So I think we just have to merge the envs: services:
zammad-nginx:
<<: *zammad-service
environment:
<<: *zammad-environment # <-- this line
VIRTUAL_HOST: "helpdesk.domain.tld"
NGINX_SERVER_SCHEME: "https"
|
We recommend to never modify the This allows you to stay in sync with upstream changes, and it will also work with the syntax of the example files. |
Infos
Expected behavior
Actual behavior
The final solution was to omit the environment section in the zammad-nginx section and instead add the vars to the x-shared -> environment-section
Steps to reproduce the behavior
The text was updated successfully, but these errors were encountered: