Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gpu): simplify 4090 bench workflow #1427

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

agnesLeroy
Copy link
Contributor

@agnesLeroy agnesLeroy commented Jul 26, 2024

closes: please link all relevant issues

PR content/description

I'm keeping only 64-bit benchmarks for multi-bit default operations. 256-bit scalar div gives an out of memory error, and I had to reduce the number of inputs for the multi-bit PBS throughput measurement, otherwise I was also getting an out of memory error.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@agnesLeroy agnesLeroy requested a review from pdroalves July 26, 2024 07:40
@cla-bot cla-bot bot added the cla-signed label Jul 26, 2024
@agnesLeroy agnesLeroy added 4090_bench Launch integer bench on our CI 4090 desktop and removed cla-signed labels Jul 26, 2024
@github-actions github-actions bot removed the 4090_bench Launch integer bench on our CI 4090 desktop label Jul 26, 2024
@agnesLeroy agnesLeroy force-pushed the al/simplify_4090_bench branch from e2cc329 to 5a64c69 Compare July 26, 2024 07:45
@cla-bot cla-bot bot added the cla-signed label Jul 26, 2024
@agnesLeroy agnesLeroy added the 4090_bench Launch integer bench on our CI 4090 desktop label Jul 26, 2024
@github-actions github-actions bot removed the 4090_bench Launch integer bench on our CI 4090 desktop label Jul 26, 2024
@agnesLeroy agnesLeroy force-pushed the al/simplify_4090_bench branch from 5a64c69 to 7475db2 Compare July 26, 2024 09:24
@agnesLeroy agnesLeroy added the 4090_bench Launch integer bench on our CI 4090 desktop label Jul 26, 2024
@agnesLeroy agnesLeroy force-pushed the al/simplify_4090_bench branch from 7475db2 to dce7f44 Compare July 26, 2024 09:28
@agnesLeroy agnesLeroy force-pushed the al/simplify_4090_bench branch from dce7f44 to 3ea3e2a Compare July 26, 2024 10:00
@github-actions github-actions bot removed the 4090_bench Launch integer bench on our CI 4090 desktop label Jul 26, 2024
@agnesLeroy agnesLeroy added the 4090_bench Launch integer bench on our CI 4090 desktop label Jul 26, 2024
@github-actions github-actions bot removed the 4090_bench Launch integer bench on our CI 4090 desktop label Jul 26, 2024
@agnesLeroy agnesLeroy requested review from IceTDrinker and removed request for pdroalves July 26, 2024 11:58
@agnesLeroy
Copy link
Contributor Author

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx !

@agnesLeroy agnesLeroy merged commit 6f1a9bd into main Jul 26, 2024
104 checks passed
@agnesLeroy agnesLeroy deleted the al/simplify_4090_bench branch July 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants