feat(integer): improve carry propagation algorithm #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
force-pushed
the
tm/faster-carry-prop
branch
2 times, most recently
from
e40a339 to
46290c2
Compare
tmontaigu
force-pushed
the
tm/faster-carry-prop
branch
2 times, most recently
from
3ac064a to
599fa1f
Compare
|
the GPU crash is what you reported to the GPU team ? |
IceTDrinker
reviewed
Jul 23, 2024
tfhe/src/integer/server_key/radix_parallel/tests_unsigned/test_add.rs
Outdated
Show resolved
Hide resolved
tfhe/src/integer/server_key/radix_parallel/tests_unsigned/test_add.rs
Outdated
Show resolved
Hide resolved
tfhe/src/integer/server_key/radix_parallel/tests_unsigned/test_add.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+1267
to
+1311
| for i in 1..grouping_size { | ||
| let state_fn = |block| { | ||
| let r = if block >= message_modulus { | ||
| 2 // Generates Carry | ||
| } else if block == message_modulus - 1 { |
There was a problem hiding this comment.
IIRC from your sprint demo this is one of the genius part of the new algo, a small illustration might be useful to show how the addition of the bits will naturally compute the propagation
|
Yes the GPU crash is the thing I reported and a PR that has the fix has been openned |
tmontaigu
force-pushed
the
tm/faster-carry-prop
branch
2 times, most recently
from
79967a7 to
b3f7e39
Compare
IceTDrinker
reviewed
Jul 25, 2024
| let carry = self.create_trivial_boolean_block(true); | ||
| let mut result = lhs.clone(); | ||
| let overflowed = self | ||
| .advanced_add_assign_with_carry_sequential_parallelized( |
There was a problem hiding this comment.
parallelized algo in sequential non parallel code ?
Btw should we get rid of the non parallel code ?
There was a problem hiding this comment.
The parallel sequential only uses 2 threads at a time so its okayish
And yes I don't think non parallel code provide much value
IceTDrinker
reviewed
Jul 25, 2024
IceTDrinker
reviewed
Jul 25, 2024
tmontaigu
force-pushed
the
tm/faster-carry-prop
branch
from
de7b9d1 to
2574083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo