From 0447f5865bb85e76d14d0468e7d9fb67078f68fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Test=C3=A9?= Date: Thu, 16 May 2024 09:15:33 +0200 Subject: [PATCH 1/4] WIP: try to trigger tests with simple changes --- tfhe/src/boolean/mod.rs | 1 + tfhe/src/c_api/mod.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/tfhe/src/boolean/mod.rs b/tfhe/src/boolean/mod.rs index 829589e8f9..e0e4dcd5cd 100644 --- a/tfhe/src/boolean/mod.rs +++ b/tfhe/src/boolean/mod.rs @@ -99,6 +99,7 @@ pub(crate) fn random_integer() -> u32 { rng.gen::() } // A simple change +// A second simple change /// Generate a couple of client and server keys with the default cryptographic parameters: /// `DEFAULT_PARAMETERS`. diff --git a/tfhe/src/c_api/mod.rs b/tfhe/src/c_api/mod.rs index 2bbd039464..2b8a7e4d0a 100644 --- a/tfhe/src/c_api/mod.rs +++ b/tfhe/src/c_api/mod.rs @@ -10,3 +10,4 @@ pub mod shortint; pub(crate) mod utils; // A simple change +// A second simple change \ No newline at end of file From 5a03e1723ee9c8122ea2502454c3778b79b3b95a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Test=C3=A9?= Date: Thu, 16 May 2024 09:24:53 +0200 Subject: [PATCH 2/4] WIP: debug action --- .github/workflows/aws_tfhe_tests.yml | 13 +++++++++++++ tfhe/src/boolean/mod.rs | 1 + 2 files changed, 14 insertions(+) diff --git a/.github/workflows/aws_tfhe_tests.yml b/.github/workflows/aws_tfhe_tests.yml index 353f396561..26e9025adb 100644 --- a/.github/workflows/aws_tfhe_tests.yml +++ b/.github/workflows/aws_tfhe_tests.yml @@ -71,6 +71,19 @@ jobs: - tfhe/docs/** - README.md + - name: Echo results + run: | + echo "core_crypto_test: ${{ steps.changed-files.outputs.core_crypto_any_changed }}" + echo "boolean_test: ${{ steps.changed-files.outputs.boolean_any_changed }}" + echo "shortint_test: ${{ steps.changed-files.outputs.shortint_any_changed }}" + echo "c_api_test: ${{ steps.changed-files.outputs.c_api_any_changed }}" + echo "high_level_api_test: ${{ steps.changed-files.outputs.high_level_api_any_changed }}" + echo "examples_test: ${{ steps.changed-files.outputs.examples_any_changed }}" + echo "zk_pok_test: ${{ steps.changed-files.outputs.zk_pok_any_changed }}" + echo "csprng_test: ${{ steps.changed-files.outputs.csprng_any_changed }}" + echo "apps_test: ${{ steps.changed-files.outputs.apps_any_changed }}" + echo "user_docs_test: ${{ steps.changed-files.outputs.user_docs_any_changed }}" + echo "any_file_changed: ${{ steps.changed-files.outputs.any_changed }}" # TODO Ajouter une étape qui aggrège tous les résultats de "any_changed" en utilisant un any() setup-instance: diff --git a/tfhe/src/boolean/mod.rs b/tfhe/src/boolean/mod.rs index e0e4dcd5cd..7174b3da45 100644 --- a/tfhe/src/boolean/mod.rs +++ b/tfhe/src/boolean/mod.rs @@ -100,6 +100,7 @@ pub(crate) fn random_integer() -> u32 { } // A simple change // A second simple change +// Again a change /// Generate a couple of client and server keys with the default cryptographic parameters: /// `DEFAULT_PARAMETERS`. From 867c055ebd8f2ca63f488dd18754096f7ec99e47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Test=C3=A9?= Date: Thu, 16 May 2024 09:35:19 +0200 Subject: [PATCH 3/4] WIP: debug action 2 --- .github/workflows/aws_tfhe_tests.yml | 2 +- tfhe/src/boolean/mod.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/aws_tfhe_tests.yml b/.github/workflows/aws_tfhe_tests.yml index 26e9025adb..ab5ccf337a 100644 --- a/.github/workflows/aws_tfhe_tests.yml +++ b/.github/workflows/aws_tfhe_tests.yml @@ -108,7 +108,7 @@ jobs: cpu-tests: name: CPU tests - needs: setup-instance + needs: [ file-change, setup-instance ] concurrency: group: ${{ github.workflow }}_${{ github.ref }} cancel-in-progress: true diff --git a/tfhe/src/boolean/mod.rs b/tfhe/src/boolean/mod.rs index 7174b3da45..b1f7da2394 100644 --- a/tfhe/src/boolean/mod.rs +++ b/tfhe/src/boolean/mod.rs @@ -101,6 +101,7 @@ pub(crate) fn random_integer() -> u32 { // A simple change // A second simple change // Again a change +// Blaaaaaaaaah /// Generate a couple of client and server keys with the default cryptographic parameters: /// `DEFAULT_PARAMETERS`. From 104bd7b74c7d78d49bed832a119817adde98f837 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Test=C3=A9?= Date: Thu, 16 May 2024 10:16:47 +0200 Subject: [PATCH 4/4] WIP: aggregate file changes --- .github/workflows/aws_tfhe_fast_tests.yml | 2 +- .github/workflows/aws_tfhe_tests.yml | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/aws_tfhe_fast_tests.yml b/.github/workflows/aws_tfhe_fast_tests.yml index 9503e97849..38cdbefc54 100644 --- a/.github/workflows/aws_tfhe_fast_tests.yml +++ b/.github/workflows/aws_tfhe_fast_tests.yml @@ -15,7 +15,7 @@ env: on: # Allows you to run this workflow manually from the Actions tab as an alternative. workflow_dispatch: - pull_request: + ############"pull_request: debug workflow_call: secrets: SLAB_ACTION_TOKEN: diff --git a/.github/workflows/aws_tfhe_tests.yml b/.github/workflows/aws_tfhe_tests.yml index ab5ccf337a..3cd5f8c98b 100644 --- a/.github/workflows/aws_tfhe_tests.yml +++ b/.github/workflows/aws_tfhe_tests.yml @@ -36,7 +36,7 @@ jobs: csprng_test: ${{ steps.changed-files.outputs.csprng_any_changed }} apps_test: ${{ steps.changed-files.outputs.apps_any_changed }} user_docs_test: ${{ steps.changed-files.outputs.user_docs_any_changed }} - any_file_changed: ${{ steps.changed-files.outputs.any_changed }} + any_file_changed: ${{ steps.aggregated-changes.outputs.any_changed }} steps: - name: Checkout tfhe-rs uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b @@ -71,6 +71,13 @@ jobs: - tfhe/docs/** - README.md + - name: Aggregate file changes + id: aggregated-changes + if: ( steps.changed-files.outputs.core_crypto_any_changed == 'true' || + steps.changed-files.outputs.shortint_any_changed == 'true' ) + run: | + echo "any_changed=true" >> "$GITHUB_OUTPUT" + - name: Echo results run: | echo "core_crypto_test: ${{ steps.changed-files.outputs.core_crypto_any_changed }}" @@ -83,12 +90,12 @@ jobs: echo "csprng_test: ${{ steps.changed-files.outputs.csprng_any_changed }}" echo "apps_test: ${{ steps.changed-files.outputs.apps_any_changed }}" echo "user_docs_test: ${{ steps.changed-files.outputs.user_docs_any_changed }}" - echo "any_file_changed: ${{ steps.changed-files.outputs.any_changed }}" + echo "any_file_changed: ${{ steps.aggregated-changes.outputs.any_changed }}" # TODO Ajouter une étape qui aggrège tous les résultats de "any_changed" en utilisant un any() setup-instance: name: Setup instance (cpu-tests) - #if: ${{ github.event_name == 'pull_request' && needs.file-change.outputs.any_file_changed == 'true' }} + if: ${{ github.event_name == 'pull_request' && needs.file-change.outputs.any_file_changed == 'true' }} ###############if: ${{ github.event_name == 'workflow_dispatch' || contains(github.event.label.name, 'approved') }} needs: file-change runs-on: ubuntu-latest