From cf3c28b26d07ded97463ecb7112b6000cb3cc1f6 Mon Sep 17 00:00:00 2001
From: tmontaigu <thomas.montaigu@laposte.net>
Date: Tue, 27 Aug 2024 10:05:37 +0200
Subject: [PATCH] chore(pr): comments

---
 tfhe/src/high_level_api/integers/signed/base.rs   |  4 ++--
 tfhe/src/high_level_api/integers/unsigned/base.rs |  4 ++--
 tfhe/src/integer/server_key/radix/even_odd.rs     | 14 ++------------
 3 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/tfhe/src/high_level_api/integers/signed/base.rs b/tfhe/src/high_level_api/integers/signed/base.rs
index 43f1726b36..8578da58a4 100644
--- a/tfhe/src/high_level_api/integers/signed/base.rs
+++ b/tfhe/src/high_level_api/integers/signed/base.rs
@@ -173,11 +173,11 @@ where
     /// let (client_key, server_key) = generate_keys(ConfigBuilder::default());
     /// set_server_key(server_key);
     ///
-    /// let a = FheInt16::encrypt(1i16, &client_key);
+    /// let a = FheInt16::encrypt(46i16, &client_key);
     ///
     /// let result = a.is_even();
     /// let decrypted = result.decrypt(&client_key);
-    /// assert!(!decrypted);
+    /// assert!(decrypted);
     /// ```
     pub fn is_even(&self) -> FheBool {
         global_state::with_internal_keys(|key| match key {
diff --git a/tfhe/src/high_level_api/integers/unsigned/base.rs b/tfhe/src/high_level_api/integers/unsigned/base.rs
index eb6d4ef9a2..2c301b552a 100644
--- a/tfhe/src/high_level_api/integers/unsigned/base.rs
+++ b/tfhe/src/high_level_api/integers/unsigned/base.rs
@@ -215,11 +215,11 @@ where
     /// let (client_key, server_key) = generate_keys(ConfigBuilder::default());
     /// set_server_key(server_key);
     ///
-    /// let a = FheUint16::encrypt(32u16, &client_key);
+    /// let a = FheUint16::encrypt(4393u16, &client_key);
     ///
     /// let result = a.is_odd();
     /// let decrypted = result.decrypt(&client_key);
-    /// assert!(!decrypted);
+    /// assert!(decrypted);
     /// ```
     pub fn is_odd(&self) -> FheBool {
         global_state::with_internal_keys(|key| match key {
diff --git a/tfhe/src/integer/server_key/radix/even_odd.rs b/tfhe/src/integer/server_key/radix/even_odd.rs
index e8b756b29f..e3a5ff8ad5 100644
--- a/tfhe/src/integer/server_key/radix/even_odd.rs
+++ b/tfhe/src/integer/server_key/radix/even_odd.rs
@@ -43,30 +43,20 @@ impl ServerKey {
     }
 
     /// Returns an encryption of true if the value is even
+    #[allow(unused_mut)]
     pub fn smart_is_even_parallelized<T>(&self, ct: &mut T) -> BooleanBlock
     where
         T: IntegerRadixCiphertext,
     {
-        // Even though we don't need to worry about carries,
-        // we still clean them
-        if !ct.block_carries_are_empty() {
-            self.full_propagate_parallelized(ct);
-        }
-
         self.unchecked_is_even(ct)
     }
 
     /// Returns an encryption of true if the value is odd
+    #[allow(unused_mut)]
     pub fn smart_is_odd_parallelized<T>(&self, ct: &mut T) -> BooleanBlock
     where
         T: IntegerRadixCiphertext,
     {
-        // Even though we don't need to worry about carries,
-        // we still clean them
-        if !ct.block_carries_are_empty() {
-            self.full_propagate_parallelized(ct);
-        }
-
         self.unchecked_is_odd(ct)
     }