Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more visibility into admissionControl span tag #3317

Open
RomanZavodskikh opened this issue Nov 22, 2024 · 0 comments
Open

Add more visibility into admissionControl span tag #3317

RomanZavodskikh opened this issue Nov 22, 2024 · 0 comments
Assignees
@RomanZavodskikh
Labels
minor no risk changes, for example new filters monitoring Metrics related changes

Comments

@RomanZavodskikh
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some visibility of admissionControl is missing, for example, it is impossible to filter all spans for specific admissionController filter at the moment.

Describe the solution you would like
Add additional span tag(s) in this span
https://github.com/zalando/skipper/blob/v0.21.223/filters/shedder/admission.go#L413

Would you like to work on it?
Yes
@RomanZavodskikh RomanZavodskikh added monitoring Metrics related changes minor no risk changes, for example new filters labels Nov 22, 2024
@RomanZavodskikh RomanZavodskikh self-assigned this Nov 22, 2024
RomanZavodskikh pushed a commit that referenced this issue Nov 22, 2024
Add more tags to the admissionControl span to increase visibility
3abb644 
Updates #3317

Signed-off-by: Roman Zavodskikh <[email protected]>
@RomanZavodskikh RomanZavodskikh mentioned this issue Nov 22, 2024
Merged
RomanZavodskikh pushed a commit that referenced this issue Nov 27, 2024
Add more tags to the admissionControl span to increase visibility
e78c6ee 
Updates #3317

Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh pushed a commit that referenced this issue Dec 17, 2024
Add more tags to the admissionControl span to increase visibility
bebd68b 
Updates #3317

Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh pushed a commit that referenced this issue Dec 17, 2024
Add more tags to the admissionControl span to increase visibility
26aa11a 
Updates #3317

Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh added a commit that referenced this issue Dec 17, 2024
@RomanZavodskikh
Add more tags to the admissionControl span to increase visibility (#3318
0e1938a 
)

Updates #3317

Signed-off-by: Roman Zavodskikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanZavodskikh RomanZavodskikh

Labels
minor no risk changes, for example new filters monitoring Metrics related changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RomanZavodskikh