Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip generates warnings in React StrictMode #610

Open
targos opened this issue Dec 15, 2023 · 5 comments
Open

Tooltip generates warnings in React StrictMode #610

targos opened this issue Dec 15, 2023 · 5 comments

Comments

@targos
Copy link
Member

targos commented Dec 15, 2023

Add strictMode: true to .storybook/main.ts

And npm run storybook:

CleanShot 2023-12-15 at 11 25 25
@stropitek
Copy link
Contributor

No I think blueprintjs is still using those APIs in non legacy components and that should change in v6

palantir/blueprint#5503

@stropitek
Copy link
Contributor

More specifically: palantir/blueprint#5503 (comment)

@targos
Copy link
Member Author

targos commented Dec 15, 2023

So we can't silence this warning in the mean time?

@targos
Copy link
Member Author

targos commented Dec 15, 2023

This is noisy in NMRium and there's now a big risk to miss other warnings and errors in the console.

@stropitek
Copy link
Contributor

So we can't silence this warning in the mean time?

No. facebook/react#16362

Only options I see is contribute to blueprintjs to make it faster or use another tooltip component in the mean time.

targos added a commit to cheminfo/nmrium that referenced this issue Dec 15, 2023
@targos
fix: Blueprint-related warnings
091fea3 
- Disable React StrictMode.
- Do not pass `isOpen` to div.

Refs: zakodium-oss/react-science#610
@targos targos mentioned this issue Dec 15, 2023
Merged
targos added a commit to cheminfo/nmrium that referenced this issue Dec 15, 2023
@targos
fix: Blueprint-related warnings (#2808)
6618ec1 
- Disable React StrictMode.
- Do not pass `isOpen` to div.

Refs: zakodium-oss/react-science#610
@targos targos changed the title Wrong Blueprint API used for tooltip? Tooltip generates warnings in React StrictMode Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @stropitek