From c41ece2e7e0bf934a2553b2311de0dc39f4ffdb7 Mon Sep 17 00:00:00 2001 From: Chmouel Boudjnah Date: Thu, 5 Dec 2024 08:37:56 +0100 Subject: [PATCH] Use old async timer chan for e2e tests We are getting some flakyness with tests crashing on time.Sleep. I am guessing it's a go1.23 change that is causing this, see: https://go.dev/wiki/Go123Timer try to use the old async timer chan to see if it fixes the issue. --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4bf8b1d2c..b6d075473 100644 --- a/Makefile +++ b/Makefile @@ -73,7 +73,8 @@ test-e2e-cleanup: ## cleanup test e2e namespace/pr left open .PHONY: test-e2e test-e2e: test-e2e-cleanup ## run e2e tests - @go test $(GO_TEST_FLAGS) -timeout $(TIMEOUT_E2E) -failfast -count=1 -tags=e2e $(GO_TEST_FLAGS) ./test + @env GODEBUG=asynctimerchan=1 \ + go test $(GO_TEST_FLAGS) -timeout $(TIMEOUT_E2E) -failfast -count=1 -tags=e2e $(GO_TEST_FLAGS) ./test .PHONY: html-coverage html-coverage: ## generate html coverage