Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please keep unsafe code in sync with stdlib #29

Open
Darksonn opened this issue Jan 22, 2025 · 0 comments
Open

Please keep unsafe code in sync with stdlib #29

Darksonn opened this issue Jan 22, 2025 · 0 comments

Comments

@Darksonn
Copy link

This crate has lots of unsafe code copied from the standard library several years ago. The stdlib is updated from time to time to fix problems in its unsafe code, but since this crate does not inherit those fixes, code in allocator-api2 remains buggy.

Just to give one example, when doing a security review of this crate, the first file I looked at was splice.rs, which is missing this change, meaning that this crate is using pointer::add in violation of its safety requirements. Every other file in the vec module I looked at is also missing things that have changed in the stdlib implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant