Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nonce instead of state to store security token #133

Open
jalyna opened this issue Jul 21, 2021 · 3 comments
Open

Use nonce instead of state to store security token #133

jalyna opened this issue Jul 21, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@jalyna
Copy link
Member

jalyna commented Jul 21, 2021

Since the oauth api accepts now the nonce param (due to the open id connect changes), we might think about moving the security token to the nonce instead of the state. Also helping us to use the state for other stuff

see also https://stackoverflow.com/questions/46844285/difference-between-oauth-2-0-state-and-openid-nonce-parameter-why-state-cou

@jalyna jalyna added the enhancement New feature or request label Jul 21, 2021
@jalyna
Copy link
Member Author

jalyna commented Jul 21, 2021

@nickcampbell18 wdyt?

@nickcampbell18
Copy link
Contributor

It sounds like we might need both - is this right?:

  • If you're using login (/sessions), we're going to get an identity token back, and we can use the embedded nonce attribute as a safe alternative to the state parameter
  • If you're using connect (/connections), we won't get an identity token back, and will therefore need to use state

@jalyna
Copy link
Member Author

jalyna commented Jul 22, 2021

@nickcampbell18 you are right, I will create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants