From 0f0616b98c495f618aee6a0a7db5f302c83da8ac Mon Sep 17 00:00:00 2001 From: zacharyburnett Date: Mon, 12 Aug 2024 11:45:34 -0400 Subject: [PATCH] add review suggestions --- .github/workflows/roman_ci.yml | 9 +++++++-- .github/workflows/roman_ci_cron.yaml | 9 +++++++-- .github/workflows/tests_devdeps.yml | 9 +++++++-- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/.github/workflows/roman_ci.yml b/.github/workflows/roman_ci.yml index 926f30640..821f82183 100644 --- a/.github/workflows/roman_ci.yml +++ b/.github/workflows/roman_ci.yml @@ -16,10 +16,15 @@ on: workflow_dispatch: inputs: crds_context: - description: CRDS context + description: CRDS context (leave blank for latest) type: string required: false default: '' + crds_server: + description: CRDS server + type: string + required: false + default: https://roman-crds.stsci.edu concurrency: group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.crds_context }} @@ -54,7 +59,7 @@ jobs: setenv: | WEBBPSF_PATH: /tmp/data/webbpsf-data/ CRDS_PATH: /tmp/data/crds_cache/ - CRDS_SERVER_URL: https://roman-crds.stsci.edu + CRDS_SERVER_URL: ${{ github.event_name == 'workflow_dispatch' && inputs.crds_server || 'https://jwst-crds.stsci.edu' }} CRDS_CONTEXT: ${{ needs.crds_context.outputs.context }} CRDS_CLIENT_RETRY_COUNT: 3 CRDS_CLIENT_RETRY_DELAY_SECONDS: 20 diff --git a/.github/workflows/roman_ci_cron.yaml b/.github/workflows/roman_ci_cron.yaml index 4c8ff2ab6..f5a65ec41 100644 --- a/.github/workflows/roman_ci_cron.yaml +++ b/.github/workflows/roman_ci_cron.yaml @@ -19,10 +19,15 @@ on: workflow_dispatch: inputs: crds_context: - description: CRDS context + description: CRDS context (leave blank for latest) type: string required: false default: '' + crds_server: + description: CRDS server + type: string + required: false + default: https://roman-crds.stsci.edu concurrency: group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.crds_context }} @@ -54,7 +59,7 @@ jobs: setenv: | WEBBPSF_PATH: /tmp/data/webbpsf-data/ CRDS_PATH: /tmp/data/crds_cache/ - CRDS_SERVER_URL: https://roman-crds.stsci.edu + CRDS_SERVER_URL: ${{ github.event_name == 'workflow_dispatch' && inputs.crds_server || 'https://jwst-crds.stsci.edu' }} CRDS_CONTEXT: ${{ needs.crds_context.outputs.context }} CRDS_CLIENT_RETRY_COUNT: 3 CRDS_CLIENT_RETRY_DELAY_SECONDS: 20 diff --git a/.github/workflows/tests_devdeps.yml b/.github/workflows/tests_devdeps.yml index 3aafa8cdd..fee047a7e 100644 --- a/.github/workflows/tests_devdeps.yml +++ b/.github/workflows/tests_devdeps.yml @@ -20,10 +20,15 @@ on: workflow_dispatch: inputs: crds_context: - description: CRDS context + description: CRDS context (leave blank for latest) type: string required: false default: '' + crds_server: + description: CRDS server + type: string + required: false + default: https://roman-crds.stsci.edu concurrency: group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.crds_context }} @@ -53,7 +58,7 @@ jobs: setenv: | WEBBPSF_PATH: /tmp/data/webbpsf-data/ CRDS_PATH: /tmp/data/crds_cache/ - CRDS_SERVER_URL: https://roman-crds.stsci.edu + CRDS_SERVER_URL: ${{ github.event_name == 'workflow_dispatch' && inputs.crds_server || 'https://jwst-crds.stsci.edu' }} CRDS_CONTEXT: ${{ needs.crds_context.outputs.context }} CRDS_CLIENT_RETRY_COUNT: 3 CRDS_CLIENT_RETRY_DELAY_SECONDS: 20