Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for novelty detection and changing distance metric with local outlier factor #5

Open
sugatc opened this issue Oct 20, 2022 · 2 comments

Comments

@sugatc
Copy link

sugatc commented Oct 20, 2022

The current implementation of LOF doesn't allow changing the distance metric to 'cosine', for example or setting novelty = True which prevents it from being used for novelty detection task. It will be great if support can be added for these.

@yzhao062
Copy link
Owner

thanks for the note. to my best knowledge, these distance metrics do not play a key role in detection. I have run quite a lot of benchmarks with different settings, and the results for kNN and LOF do not change quite a lot. So it might be fine to use euclidean.

@sugatc
Copy link
Author

sugatc commented Oct 20, 2022

Thanks for your response. What about novelty detection -- I can see PyOd allows setting the parameter novelty to True. It will be useful to have this here since Pytod is much faster and can be used for large datasets. Is there a straightforward implementation of that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants