-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline tagging using # #65
Comments
Just a reminder: If it's going to be implemented, first, there should be a setting to see if they want to use hashtags, that way in case that people who use Day One would import their entries and they disable the hashtag system, then they could disable it as well on Journaley. For the parsing, we store all tags into database (which we already do, saw that on the code) then read the raw Markdown text initially before rendering. Check the difference between hash with a space (headers) and hash that does not (hashtags). When it's done, post Markdown conversion, we search the html over to check over tags with text enclosed in headings tags ( Anyone having a better idea than this? |
"When it's done, post Markdown conversion, we search the html over to check over tags with text enclosed in headings tags ( ) and put them back as hashtags."I don't get this part, are you saying tags enclosed in h1 tags as in: "# #hashtag"?
On Nov 23, 2015, 6:46 AM -0500, Clinton Cañ[email protected], wrote:
|
As it says:
Meaning, every hash becomes headings. Like example:
into:
We assume that MyCoolHashtag tag exists in our database and we search the instance of |
Oh right, because of the issue where # tag and #tag are the same in Markdown. I see now. |
Yeah, Day One can differentiate hashtags and heading 1's. I just put this here for reference, maybe I might get into that. |
Allow for inline creation of tags in the form of: "#tag"
This will require post processing since Markdown doesn't distinguish the heading "# h1" from "#h1"
There are other considerations to this feature:
More thought is needed for this feature.
The text was updated successfully, but these errors were encountered: