Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Consider growing stacks in compiler instead of iterative lowering #19

Open
yupferris opened this issue Dec 6, 2020 · 1 comment
Open

Comments

@yupferris
Copy link
Owner

I was recently made aware of this, unfortunately after converting lowering to iterative rather than recursive code!

Ofc both approaches have tradeoffs, but the code is probably overall simpler if we conditionally grow stacks, which is very important - so we may want to consider going back to the older pattern instead.

@yupferris
Copy link
Owner Author

yupferris commented Dec 7, 2020

I actually did a quick test of this for sim::ir::Expr::write, and ended up with an ICE, so I backed out - this should be properly isolated/reported when I have more time/motivation to look into it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant