Skip to content

Commit c3ef86f

Browse files
committed
quality/user.py: simplify type hint syntax using new '|' syntax instead of Optional/Union
1 parent b88c3b7 commit c3ef86f

File tree

1 file changed

+15
-19
lines changed

1 file changed

+15
-19
lines changed

src/user.py

+15-19
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import re
2727
import subprocess
2828
from logging import getLogger
29-
from typing import TYPE_CHECKING, Any, Callable, Optional, TextIO, Union, cast
29+
from typing import TYPE_CHECKING, Any, Callable, TextIO, Union, cast
3030

3131
from moulinette import Moulinette, m18n
3232
from moulinette.utils.process import check_output
@@ -62,7 +62,7 @@
6262
ADMIN_ALIASES = ["root", "admin", "admins", "webmaster", "postmaster", "abuse"]
6363

6464

65-
def user_list(fields: Optional[list[str]] = None) -> dict[str, dict[str, Any]]:
65+
def user_list(fields: list[str] | None = None) -> dict[str, dict[str, Any]]:
6666
from yunohost.utils.ldap import _get_ldap_interface
6767

6868
ldap_attrs = {
@@ -394,16 +394,16 @@ def user_delete(
394394
def user_update(
395395
operation_logger: "OperationLogger",
396396
username: str,
397-
mail: Optional[str] = None,
398-
change_password: Optional[str] = None,
397+
mail: str | None = None,
398+
change_password: str | None = None,
399399
add_mailforward: None | str | list[str] = None,
400400
remove_mailforward: None | str | list[str] = None,
401401
add_mailalias: None | str | list[str] = None,
402402
remove_mailalias: None | str | list[str] = None,
403-
mailbox_quota: Optional[str] = None,
403+
mailbox_quota: str | None = None,
404404
from_import: bool = False,
405-
fullname: Optional[str] = None,
406-
loginShell: Optional[str] = None,
405+
fullname: str | None = None,
406+
loginShell: str | None = None,
407407
):
408408
if fullname and fullname.strip():
409409
fullname = fullname.strip()
@@ -688,10 +688,6 @@ def user_info(username: str) -> dict[str, str]:
688688
def user_export() -> Union[str, "HTTPResponseType"]:
689689
"""
690690
Export users into CSV
691-
692-
Keyword argument:
693-
csv -- CSV file with columns username;firstname;lastname;password;mailbox-quota;mail;mail-alias;mail-forward;groups
694-
695691
"""
696692
import csv # CSV are needed only in this function
697693
from io import StringIO
@@ -1063,7 +1059,7 @@ def user_group_list(
10631059
def user_group_create(
10641060
operation_logger: "OperationLogger",
10651061
groupname: str,
1066-
gid: Optional[str] = None,
1062+
gid: str | None = None,
10671063
primary_group: bool = False,
10681064
sync_perm: bool = True,
10691065
) -> dict[str, str]:
@@ -1442,7 +1438,7 @@ def user_group_info(groupname: str) -> dict[str, Any]:
14421438

14431439
def user_group_add(
14441440
groupname: str, usernames: list[str], force: bool = False, sync_perm: bool = True
1445-
) -> Optional[dict[str, Any]]:
1441+
) -> dict[str, Any] | None:
14461442
"""
14471443
Add user(s) to a group
14481444
@@ -1456,7 +1452,7 @@ def user_group_add(
14561452

14571453
def user_group_remove(
14581454
groupname: str, usernames: list[str], force: bool = False, sync_perm: bool = True
1459-
) -> Optional[dict[str, Any]]:
1455+
) -> dict[str, Any] | None:
14601456
"""
14611457
Remove user(s) from a group
14621458
@@ -1472,15 +1468,15 @@ def user_group_remove(
14721468

14731469
def user_group_add_mailalias(
14741470
groupname: str, aliases: list[str], force: bool = False
1475-
) -> Optional[dict[str, Any]]:
1471+
) -> dict[str, Any] | None:
14761472
return user_group_update(
14771473
groupname, add_mailalias=aliases, force=force, sync_perm=False
14781474
)
14791475

14801476

14811477
def user_group_remove_mailalias(
14821478
groupname: str, aliases: list[str], force: bool = False
1483-
) -> Optional[dict[str, Any]]:
1479+
) -> dict[str, Any] | None:
14841480
return user_group_update(
14851481
groupname, remove_mailalias=aliases, force=force, sync_perm=False
14861482
)
@@ -1516,7 +1512,7 @@ def user_permission_update(
15161512
def user_permission_add(
15171513
permission: str,
15181514
names: list[str],
1519-
protected: Optional[bool] = None,
1515+
protected: bool | None = None,
15201516
force: bool = False,
15211517
sync_perm: bool = True,
15221518
):
@@ -1531,7 +1527,7 @@ def user_permission_add(
15311527
def user_permission_remove(
15321528
permission: str,
15331529
names: list[str],
1534-
protected: Optional[bool] = None,
1530+
protected: bool | None = None,
15351531
force: bool = False,
15361532
sync_perm: bool = True,
15371533
):
@@ -1566,7 +1562,7 @@ def user_ssh_list_keys(username: str) -> dict[str, dict[str, str]]:
15661562
return yunohost.ssh.user_ssh_list_keys(username)
15671563

15681564

1569-
def user_ssh_add_key(username: str, key: str, comment: Optional[str] = None) -> None:
1565+
def user_ssh_add_key(username: str, key: str, comment: str | None = None) -> None:
15701566
return yunohost.ssh.user_ssh_add_key(username, key, comment)
15711567

15721568

0 commit comments

Comments
 (0)