Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows support #182

Open
5 tasks
PierreMacherel opened this issue Oct 10, 2020 · 1 comment
Open
5 tasks

windows support #182

PierreMacherel opened this issue Oct 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@PierreMacherel
Copy link

Hi,
I would like to add windows support to your project if you are OK with that.
There are multiples points to do:

  • redirection like 2> /dev/null is 2>nul on windows
  • bin/git_actions_preview and bin/preview_yankround_register are in bash. Bash is not on windows by default.
  • fzf is able to escape some character if options are provided as array of string instead of one unique string (needed for the %).
  • (optional) use cross-env to set environment variable used in package.json script
  • every thing i did not think of

Item 1 & 2 may need to check the OS.
Item 3 is easy.

Let me know if you would accept one (or multiple) PR on the subject.
Thanks for your project :)

@yuki-yano
Copy link
Owner

Thanks.
I don't have Windows, but would welcome a PR as long as it doesn't break the Mac and Linux environment.

@yuki-yano yuki-yano added the enhancement New feature or request label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants