From 78804521aab6ef23f108ff07b50dd621a9e7dcb5 Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Fri, 20 Sep 2024 13:52:05 -0700 Subject: [PATCH 01/11] Add GCC 12 and GCC 13 --- .github/workflows/ci.yml | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fee408fc..d6a6a449 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -119,15 +119,29 @@ jobs: - name: almalinux8-x86_64-gcc11 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-13T18_52_52 + docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-20T20_33_55 build_thirdparty_args: >- --devtoolset=11 architecture: x86_64 + - name: almalinux8-x86_64-gcc12 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-20T20_33_55 + build_thirdparty_args: >- + --devtoolset=12 + architecture: x86_64 + + - name: almalinux8-x86_64-gcc13 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-20T20_33_55 + build_thirdparty_args: >- + --devtoolset=13 + architecture: x86_64 + # Clang/LLVM 17 - name: almalinux8-x86_64-clang17 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-13T18_52_52 + docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-20T20_33_55 build_thirdparty_args: >- --toolchain=llvm17 architecture: x86_64 @@ -136,14 +150,14 @@ jobs: # TODO: enable ASAN/TSAN for Clang 18. - name: almalinux8-x86_64-clang18 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-13T18_52_52 + docker_image: yugabyteci/yb_build_infra_almalinux8_x86_64:v2024-09-20T20_33_55 build_thirdparty_args: >- --toolchain=llvm18 --skip-sanitizers architecture: x86_64 # --------------------------------------------------------------------------------------- - # Ubuntu 23.04 + # Ubuntu 24.04 # --------------------------------------------------------------------------------------- - name: ubuntu2404-x86_64-gcc13 @@ -166,6 +180,13 @@ jobs: --devtoolset=12 architecture: x86_64 + - name: almalinux9-x86_64-gcc13 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-13T18_52_52 + build_thirdparty_args: >- + --devtoolset=13 + architecture: x86_64 + - name: almalinux9-x86_64-clang17 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-13T18_52_52 From b4d0f49b3c45b65f30123160d2e0ba45b9c383d5 Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Fri, 20 Sep 2024 15:42:13 -0700 Subject: [PATCH 02/11] Update Docker image for AlmaLinux 9 x86_64 --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d6a6a449..0db44570 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -175,21 +175,21 @@ jobs: - name: almalinux9-x86_64-gcc12 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-13T18_52_52 + docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-20T20_33_54 build_thirdparty_args: >- --devtoolset=12 architecture: x86_64 - name: almalinux9-x86_64-gcc13 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-13T18_52_52 + docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-20T20_33_54 build_thirdparty_args: >- --devtoolset=13 architecture: x86_64 - name: almalinux9-x86_64-clang17 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-13T18_52_52 + docker_image: yugabyteci/yb_build_infra_almalinux9_x86_64:v2024-09-20T20_33_54 build_thirdparty_args: >- --toolchain=llvm17 architecture: x86_64 From e1e128b2ff4f06d623f7582474def660b55930b5 Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Fri, 20 Sep 2024 20:02:44 -0700 Subject: [PATCH 03/11] Add Ubuntu build types for GCC 11, 12, 13 --- .github/workflows/ci.yml | 73 +++++++++++++++++++++++++++++++--------- 1 file changed, 58 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0db44570..5905a5de 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,16 +60,72 @@ jobs: - name: ubuntu2204-x86_64-gcc11 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-13T18_52_51 + docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-20T23_57_46 build_thirdparty_args: >- --compiler-prefix=/usr --compiler-family=gcc --compiler-suffix=-11 architecture: x86_64 + - name: ubuntu2204-x86_64-gcc12 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-20T23_57_46 + build_thirdparty_args: >- + --compiler-prefix=/usr + --compiler-family=gcc + --compiler-suffix=-12 + architecture: x86_64 + + - name: ubuntu2204-x86_64-gcc13 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-20T23_57_46 + build_thirdparty_args: >- + --compiler-prefix=/usr + --compiler-family=gcc + --compiler-suffix=-13 + architecture: x86_64 + - name: ubuntu2204-x86_64-clang17 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-13T18_52_51 + docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-20T23_57_46 + build_thirdparty_args: >- + --toolchain=llvm17 + architecture: x86_64 + + # --------------------------------------------------------------------------------------- + # Ubuntu 24.04 + # --------------------------------------------------------------------------------------- + + - name: ubuntu2404-x86_64-gcc11 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_ubuntu2404_x86_64:v2024-09-20T23_57_48 + build_thirdparty_args: >- + --compiler-prefix=/usr + --compiler-family=gcc + --compiler-suffix=-11 + architecture: x86_64 + + - name: ubuntu2404-x86_64-gcc12 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_ubuntu2404_x86_64:v2024-09-20T23_57_48 + build_thirdparty_args: >- + --compiler-prefix=/usr + --compiler-family=gcc + --compiler-suffix=-12 + architecture: x86_64 + + - name: ubuntu2404-x86_64-gcc13 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_ubuntu2404_x86_64:v2024-09-20T23_57_48 + build_thirdparty_args: >- + --compiler-prefix=/usr + --compiler-family=gcc + --compiler-suffix=-13 + architecture: x86_64 + + - name: ubuntu2404-x86_64-clang17 + os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. + docker_image: yugabyteci/yb_build_infra_ubuntu2404_x86_64:v2024-09-20T23_57_48 build_thirdparty_args: >- --toolchain=llvm17 architecture: x86_64 @@ -156,19 +212,6 @@ jobs: --skip-sanitizers architecture: x86_64 - # --------------------------------------------------------------------------------------- - # Ubuntu 24.04 - # --------------------------------------------------------------------------------------- - - - name: ubuntu2404-x86_64-gcc13 - os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_ubuntu2404_x86_64:v2024-09-13T18_52_51 - build_thirdparty_args: >- - --compiler-prefix=/usr - --compiler-suffix=-13 - --compiler-family=gcc - architecture: x86_64 - # --------------------------------------------------------------------------------------- # AlmaLinux 9 # --------------------------------------------------------------------------------------- From fa62434dbf3d4c071bb9dfcd88d51e4c468d13ac Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Fri, 20 Sep 2024 20:22:48 -0700 Subject: [PATCH 04/11] Remove GCC 13 from Ubuntu 22.04 --- .github/workflows/ci.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5905a5de..aea4970b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -76,15 +76,6 @@ jobs: --compiler-suffix=-12 architecture: x86_64 - - name: ubuntu2204-x86_64-gcc13 - os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-20T23_57_46 - build_thirdparty_args: >- - --compiler-prefix=/usr - --compiler-family=gcc - --compiler-suffix=-13 - architecture: x86_64 - - name: ubuntu2204-x86_64-clang17 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. docker_image: yugabyteci/yb_build_infra_ubuntu2204_x86_64:v2024-09-20T23_57_46 From 9d20ba8f707623843f3c0f9bed0f9164474a9e8c Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Sat, 21 Sep 2024 01:18:28 -0700 Subject: [PATCH 05/11] Pick up Clang 17 compiler for Ubuntu 24.04; disable -Werror=reorder when buliding DiskANN with GCC 11+ --- python/build_definitions/diskann.py | 10 +++++++--- requirements_frozen.txt | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/python/build_definitions/diskann.py b/python/build_definitions/diskann.py index 98b043f9..b87a4dbc 100644 --- a/python/build_definitions/diskann.py +++ b/python/build_definitions/diskann.py @@ -124,16 +124,20 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: ignored_warnings = [] if builder.compiler_choice.is_gcc_major_version_at_least(13): - ignored_warnings = [ + ignored_warnings += [ 'overloaded-virtual', 'reorder', 'sign-compare', 'unused-but-set-variable', 'unused-variable', ] - elif builder.compiler_choice.is_clang() and \ + + if builder.compiler_choice.is_gcc_major_version_at_least(11): + ignored_warnings += ['reorder'] + + if builder.compiler_choice.is_clang() and \ builder.compiler_choice.is_llvm_major_version_at_least(18): - ignored_warnings = [ + ignored_warnings += [ 'inconsistent-missing-override', 'instantiation-after-specialization', 'nan-infinity-disabled', diff --git a/requirements_frozen.txt b/requirements_frozen.txt index 424981b8..ba5505cb 100644 --- a/requirements_frozen.txt +++ b/requirements_frozen.txt @@ -17,7 +17,7 @@ importlib-resources==6.1.0 jaraco.classes==3.3.0 jeepney==0.8.0 keyring==24.2.0 -llvm-installer==1.4.6 +llvm-installer==1.4.9 markdown-it-py==3.0.0 mdurl==0.1.2 more-itertools==10.1.0 From 58465a1f0ca5b04f1485a76ab301601e550e12c8 Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Sat, 21 Sep 2024 09:46:18 -0700 Subject: [PATCH 06/11] Try to fix DiskANN build again --- python/build_definitions/diskann.py | 46 ++++++++++++++++------------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/python/build_definitions/diskann.py b/python/build_definitions/diskann.py index b87a4dbc..7b0c37b5 100644 --- a/python/build_definitions/diskann.py +++ b/python/build_definitions/diskann.py @@ -123,32 +123,38 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: flags.append("-D__PURE_SYS_C99_HEADERS__=1") ignored_warnings = [] - if builder.compiler_choice.is_gcc_major_version_at_least(13): - ignored_warnings += [ - 'overloaded-virtual', + + if builder.compiler_choice.is_gcc_major_version_at_least(11): + ignored_warnings.extend([ 'reorder', 'sign-compare', - 'unused-but-set-variable', - 'unused-variable', - ] + ]) - if builder.compiler_choice.is_gcc_major_version_at_least(11): - ignored_warnings += ['reorder'] - - if builder.compiler_choice.is_clang() and \ - builder.compiler_choice.is_llvm_major_version_at_least(18): - ignored_warnings += [ - 'inconsistent-missing-override', - 'instantiation-after-specialization', - 'nan-infinity-disabled', + if builder.compiler_choice.is_gcc_major_version_at_least(13): + ignored_warnings.extend([ 'overloaded-virtual', - 'reorder-ctor', - 'return-type', + 'sign-compare', 'unused-but-set-variable', - 'unused-lambda-capture', - 'unused-private-field', 'unused-variable', - ] + ]) + + if builder.compiler_choice.is_clang(): + if builder.compiler_choice.is_llvm_major_version_at_least(17): + ignored_warnings.extend([ + 'unused-private-field', + ]) + if builder.compiler_choice.is_llvm_major_version_at_least(18): + ignored_warnings.extend([ + 'inconsistent-missing-override', + 'instantiation-after-specialization', + 'nan-infinity-disabled', + 'overloaded-virtual', + 'reorder-ctor', + 'return-type', + 'unused-but-set-variable', + 'unused-lambda-capture', + 'unused-variable', + ]) if ignored_warnings: flags.extend([ From a417b53438ac73dccc669502a048c3f33a7bf22e Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Sat, 21 Sep 2024 13:44:05 -0700 Subject: [PATCH 07/11] Try to fix GCC 11 and 12 issues and Clang 17 on Ubuntu 24.04 again --- .github/workflows/ci.yml | 18 +---------------- python/build_definitions/diskann.py | 30 +++++++++++++---------------- 2 files changed, 14 insertions(+), 34 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aea4970b..2c246d64 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -87,23 +87,7 @@ jobs: # Ubuntu 24.04 # --------------------------------------------------------------------------------------- - - name: ubuntu2404-x86_64-gcc11 - os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_ubuntu2404_x86_64:v2024-09-20T23_57_48 - build_thirdparty_args: >- - --compiler-prefix=/usr - --compiler-family=gcc - --compiler-suffix=-11 - architecture: x86_64 - - - name: ubuntu2404-x86_64-gcc12 - os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. - docker_image: yugabyteci/yb_build_infra_ubuntu2404_x86_64:v2024-09-20T23_57_48 - build_thirdparty_args: >- - --compiler-prefix=/usr - --compiler-family=gcc - --compiler-suffix=-12 - architecture: x86_64 + # GCC 11 and GCC 12 have DiskANN compilation issues on Ubuntu 24.04. - name: ubuntu2404-x86_64-gcc13 os: ubuntu-20.04 # Ubuntu 20.04 is for the top-level VM only. We use Docker in it. diff --git a/python/build_definitions/diskann.py b/python/build_definitions/diskann.py index 7b0c37b5..e0683e79 100644 --- a/python/build_definitions/diskann.py +++ b/python/build_definitions/diskann.py @@ -138,23 +138,19 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: 'unused-variable', ]) - if builder.compiler_choice.is_clang(): - if builder.compiler_choice.is_llvm_major_version_at_least(17): - ignored_warnings.extend([ - 'unused-private-field', - ]) - if builder.compiler_choice.is_llvm_major_version_at_least(18): - ignored_warnings.extend([ - 'inconsistent-missing-override', - 'instantiation-after-specialization', - 'nan-infinity-disabled', - 'overloaded-virtual', - 'reorder-ctor', - 'return-type', - 'unused-but-set-variable', - 'unused-lambda-capture', - 'unused-variable', - ]) + if (builder.compiler_choice.is_clang() and + builder.compiler_choice.is_llvm_major_version_at_least(17)): + ignored_warnings.extend([ + 'inconsistent-missing-override', + 'instantiation-after-specialization', + 'nan-infinity-disabled', + 'overloaded-virtual', + 'reorder-ctor', + 'return-type', + 'unused-but-set-variable', + 'unused-lambda-capture', + 'unused-variable', + ]) if ignored_warnings: flags.extend([ From 23b5eeaddbc9db5a52a7153a0568eaa9839cf187 Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Sat, 21 Sep 2024 14:58:38 -0700 Subject: [PATCH 08/11] Fix codecheck --- python/build_definitions/diskann.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/build_definitions/diskann.py b/python/build_definitions/diskann.py index e0683e79..bc4045b6 100644 --- a/python/build_definitions/diskann.py +++ b/python/build_definitions/diskann.py @@ -139,7 +139,7 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: ]) if (builder.compiler_choice.is_clang() and - builder.compiler_choice.is_llvm_major_version_at_least(17)): + builder.compiler_choice.is_llvm_major_version_at_least(17)): ignored_warnings.extend([ 'inconsistent-missing-override', 'instantiation-after-specialization', From 4401637a576cac84e945175aaa8d7d26d7b8e2f1 Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Sat, 21 Sep 2024 17:16:13 -0700 Subject: [PATCH 09/11] Do not try to disable unknown warnings in Clang 17 --- python/build_definitions/diskann.py | 30 ++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/python/build_definitions/diskann.py b/python/build_definitions/diskann.py index bc4045b6..0d024031 100644 --- a/python/build_definitions/diskann.py +++ b/python/build_definitions/diskann.py @@ -138,19 +138,23 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: 'unused-variable', ]) - if (builder.compiler_choice.is_clang() and - builder.compiler_choice.is_llvm_major_version_at_least(17)): - ignored_warnings.extend([ - 'inconsistent-missing-override', - 'instantiation-after-specialization', - 'nan-infinity-disabled', - 'overloaded-virtual', - 'reorder-ctor', - 'return-type', - 'unused-but-set-variable', - 'unused-lambda-capture', - 'unused-variable', - ]) + if builder.compiler_choice.is_clang(): + if builder.compiler_choice.is_llvm_major_version_at_least(17): + ignored_warnings.extend([ + 'inconsistent-missing-override', + 'overloaded-virtual', + 'reorder-ctor', + 'return-type', + 'unused-but-set-variable', + 'unused-lambda-capture', + 'unused-variable', + ]) + + if builder.compiler_choice.is_llvm_major_version_at_least(18): + ignored_warnings.extend([ + 'instantiation-after-specialization', + 'nan-infinity-disabled', + ]) if ignored_warnings: flags.extend([ From a39f88f99f1bf031258fe5a78516121247782e34 Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Sat, 21 Sep 2024 20:41:44 -0700 Subject: [PATCH 10/11] Ignore the unused-private-field error on Ubuntu 24.04 when building with Clang 17 --- python/build_definitions/diskann.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/build_definitions/diskann.py b/python/build_definitions/diskann.py index 0d024031..651fafba 100644 --- a/python/build_definitions/diskann.py +++ b/python/build_definitions/diskann.py @@ -147,6 +147,7 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: 'return-type', 'unused-but-set-variable', 'unused-lambda-capture', + 'unused-private-field', 'unused-variable', ]) From bfb6d70f9b4779a50c380e4bc944b646f5ac3fad Mon Sep 17 00:00:00 2001 From: Mikhail Bautin <552936+mbautin@users.noreply.github.com> Date: Sat, 21 Sep 2024 21:49:09 -0700 Subject: [PATCH 11/11] Another attempt to fix DiskANN build CI build types: ubuntu*clang* --- python/build_definitions/diskann.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/build_definitions/diskann.py b/python/build_definitions/diskann.py index 651fafba..41ec47cf 100644 --- a/python/build_definitions/diskann.py +++ b/python/build_definitions/diskann.py @@ -142,6 +142,7 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: if builder.compiler_choice.is_llvm_major_version_at_least(17): ignored_warnings.extend([ 'inconsistent-missing-override', + 'instantiation-after-specialization', 'overloaded-virtual', 'reorder-ctor', 'return-type', @@ -153,7 +154,6 @@ def get_additional_compiler_flags(self, builder: BuilderInterface) -> List[str]: if builder.compiler_choice.is_llvm_major_version_at_least(18): ignored_warnings.extend([ - 'instantiation-after-specialization', 'nan-infinity-disabled', ])