From 2fab888e999740a9aee36876d14ae378d69944e3 Mon Sep 17 00:00:00 2001 From: Karel Bilek Date: Sat, 21 Sep 2024 05:14:29 +0200 Subject: [PATCH] [skip ci] Make `build-type` option actually work (#279) Currently, the `build-type` option does not work at all and it's impossible to set it to anything. Removing `type=str` makes it actually work. Also, adds `str.lower` normalizer, so it's possible to use it with yugabyte-db main builder, which uses `uninstrumented` (lowercase) as an option. --- python/yugabyte_db_thirdparty/cmd_line_args.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/yugabyte_db_thirdparty/cmd_line_args.py b/python/yugabyte_db_thirdparty/cmd_line_args.py index 7b65f80f..6d72fc82 100644 --- a/python/yugabyte_db_thirdparty/cmd_line_args.py +++ b/python/yugabyte_db_thirdparty/cmd_line_args.py @@ -41,8 +41,7 @@ def parse_cmd_line_args() -> argparse.Namespace: parser = argparse.ArgumentParser(prog=sys.argv[0]) parser.add_argument('--build-type', default=None, - type=str, - action=enum_action(BuildType), + action=enum_action(BuildType, str.lower), help='Build only the third-party dependencies of the given type') parser.add_argument('--skip-sanitizers', action='store_true',