Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the initial handshake fails, yugatool should retry with TLS enabled / disabled #28

Open
ionthegeek opened this issue May 9, 2022 · 0 comments
Open

If the initial handshake fails, yugatool should retry with TLS enabled / disabled #28

ionthegeek opened this issue May 9, 2022 · 0 comments
Labels
enhancement New feature or request yugatool

Comments

@ionthegeek
Copy link
Contributor

ionthegeek commented May 9, 2022 •
edited
Loading

Currently if you specify any of the TLS parameters at the yugatool command line and the TLS handshake fails, the connection fails with a generic failure message.

If the TLS handshake fails, yugatool should try to establish an unencrypted connection before giving up. Similarly, if an unencrypted connection fails, it should try loading the certs from the default paths and try to establish an encrypted connection.
ionthegeek added a commit that referenced this issue Oct 12, 2022
@ionthegeek
yugatool: attempt cleartext connection if TLS connection fails
ab00119 
Partial fix for #28

This commit implements retry in cleartext if TLS connectivity fails but not vice-versa.

A complete fix will require a bit more refactoring since we have to keep track of whether we've already tried to swap from TLS to cleartext or vice-versa, otherwise we will end up in a loop.
@ionthegeek ionthegeek added enhancement New feature or request yugatool labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request yugatool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ionthegeek