-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows #211
Fix Windows #211
Conversation
@yuanqing this is ready (no more commits expected) Verified on a Windows machine with all overrides present. |
I need this, please |
@@ -16,6 +18,8 @@ import { importFresh } from '../import-fresh.js' | |||
import { esbuildCssModulesPlugin } from './esbuild-css-modules-plugin.js' | |||
import { esbuildPreactCompatPlugin } from './esbuild-preact-compat-plugin.js' | |||
|
|||
const isWindows = platform() === 'win32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a dumb question, as I haven't done any platform-specific node development, but I assume this is win32
even on 64-bit OSes?
@yuanqing Can we please get this PR merged? It's a major blocker in upgrading to the newest version for windows users |
@TheUltDev – Thanks for this! I’ve merged but made a small change to move the logic into |
Fixes #205.
This change appends the
file://
protocol to windows paths to the error below(technically we let
pathToFileURL
fromnode:url
do the work)