-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: can we drop support for Python 3.9 now ? #4977
Comments
(this shouldn't block the 4.4.0 release, I'm just hoping it could be resolved by then) |
I'm not doing anything beside what was mentioned here: #4302 (comment) Is it publicly visible? Yes, it's in every log:
|
Is there something specific about the nose tests that makes them difficult to switch to pytest? I.e., is there some technical issue to resolve there? Or is it just a whole lot of work nobody's really gotten around to or committed to? Because in the second case, we could try opening up a sign-up sheet or something, or start off with a zoom co-working session or something to try to kick things off. |
It's tangent to this issue so I suggest we don't pull that thread here but in short: pytest dropped support for |
+1 for dropping support for python 3.9. but until we drop nose, it'd be nice to document what you need to do to run locally in a clearer spot than this issue. how bout we add the find/sed command from @Xarthisius's comment to the note that @nastasha-w added in #4955 ? |
Good point. Done in #4979 |
It is that time of the year were a new version of Python is (about to be) born, and we can rotate out the oldest-supported one.
This one however is a bit special: Python 3.9 was the last version to work out-of-the-box with the now long-discontinued nosetest.
We already have a manually patched version of nosetest running on Jenkins with Python 3.10 so we know that's doable, but dropping Python 3.9 means it will become even harder to reproduce failures locally.
However, since there hasn't been much progress on the front of migrating our oldest tests to pytest, running the patched version of nose might still be the way to go for now.
@Xarthisius, is your patch publicly visible anywhere ? It would be useful to add it to the repo so it can be used on GHA CI too.
The text was updated successfully, but these errors were encountered: