diff --git a/content/15.development_procedure.md b/content/15.development_procedure.md index bf87663c..29bf1557 100644 --- a/content/15.development_procedure.md +++ b/content/15.development_procedure.md @@ -24,14 +24,14 @@ This particular bias, toward contributions measured in count, is one that affect To mitigate this shortcoming, we present the number of pull requests merged into the code base, as a function of time, as well as the time between their creation and their merge, in the lower row of Figure @fig:commit-graph. This demonstrates that in many cases, the number of discrete contributions to the codebase varies greatly depending on the developer, and we believe gives a more informed perception of the activity in the code base. -
+ ![ Commits and pull requests to the source code as a function of time. ](images/blank.svg){#fig:commit-graph width="1px"} In Figure @fig:pr-closing-time we have plotted distribution of pull requests based on the time between their creation and their merge. @@ -39,14 +39,14 @@ The longest time between opening a pull request and merging it was nearly four y The next longest pull request durations are for splitting the code used for bitmap indexing (see @sec:point_indexing) and a per-field configuration system. This includes only those pull requests that occurred on GitHub. - + ![ The distribution of pull requests as a function of how long it took to close them. ](images/blank.svg){#fig:pr-closing-time width="1px"} diff --git a/scripts/generate_stats.py b/scripts/generate_stats.py index c58306a1..965507a5 100644 --- a/scripts/generate_stats.py +++ b/scripts/generate_stats.py @@ -60,10 +60,10 @@ df_pr["duration"] = (df_pr["closedAt"] - df_pr["createdAt"]).dt.total_seconds() df_pr["author"] = df_pr["author.name"] -df_pr["author"].fillna(df_pr["author.login"]) -df_pr["author"].fillna(df_pr["author.id"]) -df_pr["author"].fillna("Automated Bot") -df_pr["author"][df_pr["author"] == ""] = "Automated Bot" +df_pr["author"].fillna(df_pr["author.login"], inplace=True) +df_pr["author"].fillna(df_pr["author.id"], inplace=True) +df_pr["author"].fillna("Automated Bot", inplace=True) +df_pr[df_pr["author"] == ""]["author"] = "Automated Bot" df_pr["type"] = "pull-request" df_pr.rename(columns = {'closedAt': 'datetime'}, inplace=True)