[BDGR-103] Convert desktop codebase and builds to ES Modules #482
+172
−104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fun drive-by: I think I've finally got to the bottom of why the Prisma client was getting bundled into the Desktop build (where it has no reason to end up and is effectively dead code): I needed to add
"sideEffects": false
to theutility/prisma/package.json
. Added an eslint rule against importing@badger/prisma/client
as an extra safeguard.Fixes BDGR-103, #281.