feat: made advanced settings for token creation read-only #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tushar-saxena-yral
temporarily deployed
to
pr-534
GitHub Actions
Inactive
|
@saikatdas0790 thoughts on UX suggestions? |
|
@tushar-saxena-yral Let's bring this up during today's meeting? |
rupansh-sekar-yral
previously approved these changes
Nov 27, 2024
|
https://www.figma.com/file/qly4tjTKMMbdOO4IrLzOeC?node-id=766:2199&locale=en&type=design
|
tushar-saxena-yral
temporarily deployed
to
pr-534
GitHub Actions
Inactive
tushar-saxena-yral
temporarily deployed
to
pr-534
GitHub Actions
Inactive
|
@harshita-srivastava-yral i cut some corners with the tooltip to save dev time. lemme know if you want it to be pixel perfect, otherwise i feel it will suffice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #529
Disables the fields, but the ux is a bit compromised. Should I add a bit styling and a white text saying something along the lines of
you can't change these settings? or is this good enough