From 56d05dcb75054cb64695de557b46b22d35c82a02 Mon Sep 17 00:00:00 2001
From: xiaomings <xiaomings@google.com>
Date: Mon, 30 Dec 2024 16:58:59 -0800
Subject: [PATCH] [media] Remove decode_target_internal.cc (#4631)

Removed
"//starboard/shared/starboard/decode_target/decode_target_internal.cc".
It only contains the default ctor and dtor for `SbDecodeTargetPrivate`,
and they are now moved into decode_target_internal.h to be inline.

b/327287075
---
 starboard/android/shared/BUILD.gn             |  1 -
 .../decode_target/decode_target_internal.cc   | 19 -------------------
 .../decode_target/decode_target_internal.h    |  4 ++--
 3 files changed, 2 insertions(+), 22 deletions(-)
 delete mode 100644 starboard/shared/starboard/decode_target/decode_target_internal.cc

diff --git a/starboard/android/shared/BUILD.gn b/starboard/android/shared/BUILD.gn
index c51409bf22c..cf4b70c4dd9 100644
--- a/starboard/android/shared/BUILD.gn
+++ b/starboard/android/shared/BUILD.gn
@@ -103,7 +103,6 @@ static_library("starboard_platform") {
     "//starboard/shared/starboard/command_line.cc",
     "//starboard/shared/starboard/command_line.h",
     "//starboard/shared/starboard/decode_target/decode_target_get_info.cc",
-    "//starboard/shared/starboard/decode_target/decode_target_internal.cc",
     "//starboard/shared/starboard/decode_target/decode_target_internal.h",
     "//starboard/shared/starboard/decode_target/decode_target_release.cc",
     "//starboard/shared/starboard/drm/drm_close_session.cc",
diff --git a/starboard/shared/starboard/decode_target/decode_target_internal.cc b/starboard/shared/starboard/decode_target/decode_target_internal.cc
deleted file mode 100644
index 29c40807efe..00000000000
--- a/starboard/shared/starboard/decode_target/decode_target_internal.cc
+++ /dev/null
@@ -1,19 +0,0 @@
-// Copyright 2024 The Cobalt Authors. All Rights Reserved.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#include "starboard/shared/starboard/decode_target/decode_target_internal.h"
-
-SbDecodeTargetPrivate::SbDecodeTargetPrivate() = default;
-
-SbDecodeTargetPrivate::~SbDecodeTargetPrivate() = default;
diff --git a/starboard/shared/starboard/decode_target/decode_target_internal.h b/starboard/shared/starboard/decode_target/decode_target_internal.h
index f1db07cf338..779ad897ddc 100644
--- a/starboard/shared/starboard/decode_target/decode_target_internal.h
+++ b/starboard/shared/starboard/decode_target/decode_target_internal.h
@@ -20,7 +20,7 @@
 #include "starboard/common/ref_counted.h"
 
 struct SbDecodeTargetPrivate : starboard::RefCounted<SbDecodeTargetPrivate> {
-  SbDecodeTargetPrivate();
+  SbDecodeTargetPrivate() = default;
 
   SbDecodeTargetPrivate(const SbDecodeTargetPrivate&) = delete;
   SbDecodeTargetPrivate& operator=(const SbDecodeTargetPrivate&) = delete;
@@ -30,7 +30,7 @@ struct SbDecodeTargetPrivate : starboard::RefCounted<SbDecodeTargetPrivate> {
  protected:
   friend class starboard::RefCounted<SbDecodeTargetPrivate>;
 
-  virtual ~SbDecodeTargetPrivate();
+  virtual ~SbDecodeTargetPrivate() = default;
 };
 
 #endif  // STARBOARD_SHARED_STARBOARD_DECODE_TARGET_DECODE_TARGET_INTERNAL_H_