Support namespace path or mount_label or rootfs_propagation empty in json #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespace path, mount_label, apparmorProfile or rootfs_propagation
may be set to Some("") not None, but it should be treated same as None.
Signed-off-by: Vanient <[email protected]>
|
Hey, thanks for opening this PR! |
Yes, you are right i found it should not show in json if String is "", close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use youki as crate, config.json maybe created by upper container engine not youki self, namespace path, apparmor_profile, mount_label or rootfs_propagation may be set to Some("") not None in config.json, but it should be treated same as None.